From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36930 invoked by alias); 27 Jan 2020 08:11:45 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 36903 invoked by uid 89); 27 Jan 2020 08:11:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.4 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.1 spammy=HX-Languages-Length:535 X-HELO: gnu.wildebeest.org Received: from wildebeest.demon.nl (HELO gnu.wildebeest.org) (212.238.236.112) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 27 Jan 2020 08:11:40 +0000 Received: from tarox.wildebeest.org (tarox.wildebeest.org [172.31.17.39]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by gnu.wildebeest.org (Postfix) with ESMTPSA id 8A107300D924; Mon, 27 Jan 2020 09:11:38 +0100 (CET) Received: by tarox.wildebeest.org (Postfix, from userid 1000) id 38C394058727; Mon, 27 Jan 2020 09:11:38 +0100 (CET) Message-ID: <52ecc5c02ffbfc7573c52813fea5f1b6094d35dc.camel@klomp.org> Subject: Re: [PATCH] Amend fallback comment to work with newer gcc From: Mark Wielaard To: Siddhesh Poyarekar , systemtap@sourceware.org Date: Mon, 27 Jan 2020 08:11:00 -0000 In-Reply-To: <20200127072622.345211-1-siddhesh@gotplt.org> References: <20200127072622.345211-1-siddhesh@gotplt.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 X-IsSubscribed: yes X-SW-Source: 2020-q1/txt/msg00010.txt Hi Siddhesh, On Mon, 2020-01-27 at 12:56 +0530, Siddhesh Poyarekar wrote: > Newer gcc does not recognize the fallthrough comment due to the text > following the fallthrough keyword. The "see above" doesn't seem too > valuable, so this patch drops it to fix the build. Thanks. Pushed. I am slightly surprised gcc made this stricter. But this is more consistent. This was the only place in the code base where we didn't use the bare /* fallthrough */ comment. Cheers, Mark