public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: David Smith <dsmith@redhat.com>
To: Torsten Polle <Torsten.Polle@gmx.de>, systemtap@sourceware.org
Subject: Re: [RFC] Probes don't hit in an already running process
Date: Thu, 13 Mar 2014 13:46:00 -0000	[thread overview]
Message-ID: <5321B6A7.2050908@redhat.com> (raw)
In-Reply-To: <m2zjl1y78q.fsf@gmx.de>

On 03/07/2014 04:27 PM, Torsten Polle wrote:
> Hi,
> 
> I've made the observation that probes sometimes don't hit when I start
> staprun after the process (where the probes should hit) started.  After
> some tests, I found out that only multi-thread processes were affected
> under a certain condition.
> 
> The patch below fixes the issue for me. But I've no clue about possible
> side effects. In my first attempt to fix the issue, I also included the
> calls to __stp_call_callbacks() into the guarded area. My probes hit,
> but calls to usymname(uaddr()) in the probe body only printed the
> address instead of the symbol of the probed function.
> 
> Any advice of how I can improve the patch is appreciated.

Hmm. we've had this problem before, and I thought we fixed it. See
PR12642 (utrace: taskfinder misses events when main thread does not go
through at least one quiesce):

<https://sourceware.org/bugzilla/show_bug.cgi?id=12642>

One of the things the commit that fixes that bug does is add a test
case, called 'main_quiesce.exp'. Does that pass or fail for you (run
"make installcheck RUNTESTFLAGS=main_quiesce.exp")? If it passes, we
need to figure out what is different about your multi-thread process
that still causes this to happen.

-- 
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)

  reply	other threads:[~2014-03-13 13:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-07 22:27 Torsten Polle
2014-03-13 13:46 ` David Smith [this message]
2014-03-15  6:29   ` Aw: " Torsten Polle
2014-08-16 20:51     ` Torsten Polle
2014-08-18 14:48       ` David Smith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5321B6A7.2050908@redhat.com \
    --to=dsmith@redhat.com \
    --cc=Torsten.Polle@gmx.de \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).