Re: [PATCH -tip v8 11/26] kprobes: Allow probe on some kprobe functions

[Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>]

(2014/03/25 4:37), Steven Rostedt wrote:
> On Wed, 05 Mar 2014 21:00:00 +0900
> Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> wrote:
> 
>> There is no need to prohibit probing on the functions
>> used for preparation, registeration, optimization,
>> controll etc. Those are safely probed because those are
>> not invoked from breakpoint/fault/debug handlers,
>> there is no chance to cause recursive exceptions.
>>
>> Following functions are now removed from the kprobes blacklist.
>> add_new_kprobe
>> aggr_kprobe_disabled
>> alloc_aggr_kprobe
>> alloc_aggr_kprobe
>> arm_all_kprobes
>> __arm_kprobe
>> arm_kprobe
>> arm_kprobe_ftrace
>> check_kprobe_address_safe
>> collect_garbage_slots
>> collect_garbage_slots
>> collect_one_slot
>> debugfs_kprobe_init
>> __disable_kprobe
>> disable_kprobe
>> disarm_all_kprobes
>> __disarm_kprobe
>> disarm_kprobe
>> disarm_kprobe_ftrace
>> do_free_cleaned_kprobes
>> do_optimize_kprobes
>> do_unoptimize_kprobes
>> enable_kprobe
>> force_unoptimize_kprobe
>> free_aggr_kprobe
>> free_aggr_kprobe
>> __free_insn_slot
>> __get_insn_slot
>> get_optimized_kprobe
>> __get_valid_kprobe
>> init_aggr_kprobe
>> init_aggr_kprobe
>> in_nokprobe_functions
>> kick_kprobe_optimizer
>> kill_kprobe
>> kill_optimized_kprobe
>> kprobe_addr
>> kprobe_optimizer
>> kprobe_queued
>> kprobe_seq_next
>> kprobe_seq_start
>> kprobe_seq_stop
>> kprobes_module_callback
>> kprobes_open
>> optimize_all_kprobes
>> optimize_kprobe
>> prepare_kprobe
>> prepare_optimized_kprobe
>> register_aggr_kprobe
>> register_jprobe
>> register_jprobes
>> register_kprobe
>> register_kprobes
>> register_kretprobe
>> register_kretprobe
>> register_kretprobes
>> register_kretprobes
>> report_probe
>> show_kprobe_addr
>> try_to_optimize_kprobe
>> unoptimize_all_kprobes
>> unoptimize_kprobe
>> unregister_jprobe
>> unregister_jprobes
>> unregister_kprobe
>> __unregister_kprobe_bottom
>> unregister_kprobes
>> __unregister_kprobe_top
>> unregister_kretprobe
>> unregister_kretprobe
>> unregister_kretprobes
>> unregister_kretprobes
>> wait_for_kprobe_optimizer
>>
> 
> Did you test these like you did with the previous patch? What about the
> middle of these functions?

No, not yet tested in middle of those functions. Only the entries are
tested. OK, I'll do that.

Thank you,

-- 
Masami HIRAMATSU
IT Management Research Dept. Linux Technology Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com