From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29723 invoked by alias); 25 Mar 2014 10:33:49 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 29715 invoked by uid 89); 25 Mar 2014 10:33:48 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail7.hitachi.co.jp Received: from mail7.hitachi.co.jp (HELO mail7.hitachi.co.jp) (133.145.228.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Mar 2014 10:33:47 +0000 Received: from mlsv4.hitachi.co.jp (unknown [133.144.234.166]) by mail7.hitachi.co.jp (Postfix) with ESMTP id 2592C37AC6; Tue, 25 Mar 2014 19:33:45 +0900 (JST) Received: from mfilter03.hitachi.co.jp by mlsv4.hitachi.co.jp (8.13.1/8.13.1) id s2PAXjbI032321; Tue, 25 Mar 2014 19:33:45 +0900 Received: from vshuts01.hitachi.co.jp (vshuts01.hitachi.co.jp [10.201.6.83]) by mfilter03.hitachi.co.jp (Switch-3.3.4/Switch-3.3.4) with ESMTP id s2PAXeNP032504; Tue, 25 Mar 2014 19:33:44 +0900 Received: from gxml20a.ad.clb.hitachi.co.jp (unknown [158.213.157.160]) by vshuts01.hitachi.co.jp (Postfix) with ESMTP id 7D0242F003A; Tue, 25 Mar 2014 19:33:43 +0900 (JST) Received: from [10.198.219.31] by gxml20a.ad.clb.hitachi.co.jp (Switch-3.1.10/Switch-3.1.9) id 62PA1X6H30000819C; Tue, 25 Mar 2014 19:33:42 +0900 Message-ID: <53315B83.2060509@hitachi.com> Date: Tue, 25 Mar 2014 10:33:00 -0000 From: Masami Hiramatsu User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, Ingo Molnar , Andi Kleen , Andi Kleen , Peter Zijlstra , Sandeepa Prabhu , Frederic Weisbecker , x86@kernel.org, Oleg Nesterov , fche@redhat.com, mingo@redhat.com, Arnaldo Carvalho de Melo , "H. Peter Anvin" , Thomas Gleixner , Seiji Aguchi , systemtap@sourceware.org, Ananth N Mavinakayanahalli Subject: Re: [PATCH -tip v8 14/26] x86: Use NOKPROBE_SYMBOL() instead of __kprobes annotation References: <20140305115843.22766.8355.stgit@ltc230.yrl.intra.hitachi.co.jp> <20140305120021.22766.59.stgit@ltc230.yrl.intra.hitachi.co.jp> <20140324154518.77096045@gandalf.local.home> In-Reply-To: <20140324154518.77096045@gandalf.local.home> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-q1/txt/msg00359.txt.bz2 (2014/03/25 4:45), Steven Rostedt wrote: > On Wed, 05 Mar 2014 21:00:21 +0900 > Masami Hiramatsu wrote: > >> /* >> * This is gone through when something in the kernel has done something bad >> diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86/kernel/kprobes/core.c >> index ae5aafb..d00103a 100644 >> --- a/arch/x86/kernel/kprobes/core.c >> +++ b/arch/x86/kernel/kprobes/core.c >> @@ -112,7 +112,8 @@ struct kretprobe_blackpoint kretprobe_blacklist[] = { >> >> const int kretprobe_blacklist_size = ARRAY_SIZE(kretprobe_blacklist); >> >> -static void __kprobes __synthesize_relative_insn(void *from, void *to, u8 op) >> +static nokprobe_inline >> +void __synthesize_relative_insn(void *from, void *to, u8 op) > > I believe the proper way to break this up is: > > static nokprobe_inline void > __synthesize_relative_insn(...) Oops, there are so many incorrect style hunks...:( I'll fix those. Thank you! -- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com