From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25548 invoked by alias); 21 Jul 2014 09:40:55 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 25429 invoked by uid 89); 21 Jul 2014 09:40:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 X-HELO: e23smtp05.au.ibm.com Received: from e23smtp05.au.ibm.com (HELO e23smtp05.au.ibm.com) (202.81.31.147) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 21 Jul 2014 09:40:46 +0000 Received: from /spool/local by e23smtp05.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 21 Jul 2014 19:40:40 +1000 Received: from d23dlp03.au.ibm.com (202.81.31.214) by e23smtp05.au.ibm.com (202.81.31.211) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Mon, 21 Jul 2014 19:40:38 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id C2C033578056 for ; Mon, 21 Jul 2014 19:40:33 +1000 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id s6L9NefY66977828 for ; Mon, 21 Jul 2014 19:23:40 +1000 Received: from d23av01.au.ibm.com (localhost [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id s6L9eW0I004916 for ; Mon, 21 Jul 2014 19:40:33 +1000 Received: from localhost.localdomain ([9.124.35.114]) by d23av01.au.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id s6L9eRf4004765; Mon, 21 Jul 2014 19:40:28 +1000 Message-ID: <53CCE00A.6030903@linux.vnet.ibm.com> Date: Mon, 21 Jul 2014 09:40:00 -0000 From: Hemant Kumar User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:24.0) Gecko/20100101 Thunderbird/24.6.0 MIME-Version: 1.0 To: Namhyung Kim , Andi Kleen CC: linux-kernel@vger.kernel.org, srikar@linux.vnet.ibm.com, peterz@infradead.org, oleg@redhat.com, hegdevasant@linux.vnet.ibm.com, mingo@redhat.com, anton@redhat.com, systemtap@sourceware.org, masami.hiramatsu.pt@hitachi.com, aravinda@linux.vnet.ibm.com, penberg@iki.fi Subject: Re: [PATCH v2 1/3] perf/sdt : Listing of SDT markers by perf References: <20140717054826.19995.61782.stgit@hemant-fedora> <20140717055341.19995.97042.stgit@hemant-fedora> <87d2d24kui.fsf@tassilo.jf.intel.com> <87zjg3jv0v.fsf@sejong.aot.lge.com> In-Reply-To: <87zjg3jv0v.fsf@sejong.aot.lge.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 14072109-1396-0000-0000-00000544D48F X-SW-Source: 2014-q3/txt/msg00054.txt.bz2 Hi Andi and Namhyung, On 07/21/2014 08:08 AM, Namhyung Kim wrote: > Hi Andi, > > On Fri, 18 Jul 2014 10:50:45 -0700, Andi Kleen wrote: >> Hemant Kumar writes: >>> +/* >>> + * Finds out the libraries present in a system as shown by the command >>> + * "ldconfig --print-cache". Uses "=>" and '/' to find out the start of a >>> + * dso path. >>> + */ >> This seems like a hack. How would that handle chroot, containers >> etc. ? > [SNIP] >>> +/* >>> + * Obtain the list of paths from the PATH env variable >>> + */ >> Same as above. This probably needs to be more configurable to handle >> more ways to find binaries. > Agreed. What about not to be smart? IOW, just let users specify > directories and/or files to be scanned. Maybe we can use it like: > > perf list sdt --scan $PATH > > or > > perf sdt-cache --scan /lib:/lib64 Agreed, that we need to have options to add more binaries present in directories other than the default directories. > > We can add some wrapper or default directory later if needed. > > But wasn't the whole point of changing to this patchset was to make SDT events more prominent, i.e., to display the SDTs present in the whole system? So, what I am trying to say is that, we already have the PATH bins and libs' dsos, if we need to add more, we can use : perf sdt-cache --scan [dir1][:dir2]... What would you suggest we do? -- Thanks, Hemant Kumar