From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15844 invoked by alias); 8 Aug 2014 07:24:05 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 15828 invoked by uid 89); 8 Aug 2014 07:24:04 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail7.hitachi.co.jp Received: from mail7.hitachi.co.jp (HELO mail7.hitachi.co.jp) (133.145.228.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Aug 2014 07:24:01 +0000 Received: from mlsv3.hitachi.co.jp (unknown [133.144.234.166]) by mail7.hitachi.co.jp (Postfix) with ESMTP id 1705937ACC for ; Fri, 8 Aug 2014 16:23:59 +0900 (JST) Received: from mfilter03.hitachi.co.jp by mlsv3.hitachi.co.jp (8.13.1/8.13.1) id s787Nx6o029093; Fri, 8 Aug 2014 16:23:59 +0900 Received: from vshuts01.hitachi.co.jp (vshuts01.hitachi.co.jp [10.201.6.83]) by mfilter03.hitachi.co.jp (Switch-3.3.4/Switch-3.3.4) with ESMTP id s787NwWD020544 for ; Fri, 8 Aug 2014 16:23:58 +0900 Received: from gxml20a.ad.clb.hitachi.co.jp (unknown [158.213.157.160]) by vshuts01.hitachi.co.jp (Postfix) with ESMTP id C3F182F0041; Fri, 8 Aug 2014 16:23:57 +0900 (JST) Received: from [10.198.219.54] by gxml20a.ad.clb.hitachi.co.jp (Switch-3.1.10/Switch-3.1.9) id 67871NLHN000051B4; Fri, 08 Aug 2014 16:23:57 +0900 Message-ID: <53E47B0A.3090803@hitachi.com> Date: Fri, 08 Aug 2014 07:24:00 -0000 From: Masami Hiramatsu User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: systemtap@sourceware.org Subject: Re: [PATCH 0/2] initscript: add support for uprobes scripts References: <1407479623-30970-1-git-send-email-stefanha@redhat.com> In-Reply-To: <1407479623-30970-1-git-send-email-stefanha@redhat.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-q3/txt/msg00136.txt.bz2 (2014/08/08 15:33), Stefan Hajnoczi wrote: > The initscript currently fails for user-space probing scripts on systems where > uprobes.ko is built from source by stap(1). This is because the initscript > uses a two-phase "compile and then run" approach: > > The uprobes.ko module is generated during the compile phase but not copied into > the cache directory where modules are placed for the run phase. The staprun(8) > command fails because the script module cannot be loaded without uprobes.ko. > > These patches address the issue by copying uprobes.ko into the cache directory. > If a script specifies the -u option in its initscript configuration file, > staprun(8) will receive the path to uprobes.ko. These look good to me :-) BTW, is it still working with systemd? Thanks! > > There is no change in behavior on systems that do not build uprobes.ko. > > Stefan Hajnoczi (2): > initscript: copy uprobes.ko to cache directory > initscript: allow scripts to load uprobes > > initscript/systemtap.in | 24 +++++++++++++++++++++--- > 1 file changed, 21 insertions(+), 3 deletions(-) > -- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com