From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22134 invoked by alias); 11 Nov 2014 06:53:54 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 22120 invoked by uid 89); 11 Nov 2014 06:53:53 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.5 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail9.hitachi.co.jp Received: from mail9.hitachi.co.jp (HELO mail9.hitachi.co.jp) (133.145.228.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 11 Nov 2014 06:53:51 +0000 Received: from mlsv7.hitachi.co.jp (unknown [133.144.234.166]) by mail9.hitachi.co.jp (Postfix) with ESMTP id B285D37C8A; Tue, 11 Nov 2014 15:53:48 +0900 (JST) Received: from mfilter04.hitachi.co.jp by mlsv7.hitachi.co.jp (8.13.1/8.13.1) id sAB6rmwI014765; Tue, 11 Nov 2014 15:53:48 +0900 Received: from vshuts02.hitachi.co.jp (vshuts02.hitachi.co.jp [10.201.6.84]) by mfilter04.hitachi.co.jp (Switch-3.3.4/Switch-3.3.4) with ESMTP id sAB6ri4k021072; Tue, 11 Nov 2014 15:53:48 +0900 Received: from gxml20a.ad.clb.hitachi.co.jp (unknown [158.213.157.160]) by vshuts02.hitachi.co.jp (Postfix) with ESMTP id 83BE7490042; Tue, 11 Nov 2014 15:53:47 +0900 (JST) Received: from [10.198.219.51] by gxml20a.ad.clb.hitachi.co.jp (Switch-3.1.10/Switch-3.1.9) id 6AB63HBG400003EB8; Tue, 11 Nov 2014 15:53:47 +0900 Message-ID: <5461B276.50004@hitachi.com> Date: Tue, 11 Nov 2014 06:53:00 -0000 From: Masami Hiramatsu User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Arnaldo Carvalho de Melo Cc: Hemant Kumar , Namhyung Kim , linux-kernel@vger.kernel.org, srikar@linux.vnet.ibm.com, peterz@infradead.org, oleg@redhat.com, hegdevasant@linux.vnet.ibm.com, mingo@redhat.com, systemtap@sourceware.org, aravinda@linux.vnet.ibm.com, penberg@iki.fi, brendan.d.gregg@gmail.com, "yrl.pp-manager.tt@hitachi.com" Subject: Re: [RFC] perf-cache command interface design References: <20141102105006.21708.28734.stgit@hemant-fedora> <20141102105557.21708.19032.stgit@hemant-fedora> <87lhnr5sbl.fsf@sejong.aot.lge.com> <54588905.7040002@linux.vnet.ibm.com> <5458CD15.4010101@hitachi.com> <874muew2hk.fsf@sejong.aot.lge.com> <5459E865.6050207@hitachi.com> <545B1DDE.9000202@linux.vnet.ibm.com> <545C80F4.4020905@hitachi.com> <54609A8C.4050308@hitachi.com> <20141110122321.GC4468@redhat.com> In-Reply-To: <20141110122321.GC4468@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2014-q4/txt/msg00137.txt.bz2 (2014/11/10 21:23), Arnaldo Carvalho de Melo wrote: > Em Mon, Nov 10, 2014 at 07:59:24PM +0900, Masami Hiramatsu escreveu: >> Hello, >> >> Here is the second try for the probe-cache. This version simplifies >> the synopsis, and unifies the SDT and probe caches. >> Please give me your comments/ideas! >> >> Command-line Synopsis >> ===================== >> >> Add elf(or symbols) and probe-caches of SDT if exists in >> perf cache --add [--probe ] # for user programs > > Why the --probe above? Shouldn't this be just (if you are talking about > ELF files only): > > perf cache --add Yes, for the elf and sdt cache, we don't need --probe. Note that "[]" means optional. If we would like to add some probe cache, we need a spec of probe definition. >> perf cache --kcore [--probe ] # for kcore ? > > Adrian, aren't kcore files easily identifiable as such and thus could be > added as: > > perf cache --add > >> perf cache --probe # for the current kernel > > Why do we need a --probe here? Don't they always start with a character > that is seldomly used in ELF file names and thus we could get away with > not requiring --probe? This is only for adding the probe cache (not elf, nor sdt), which requires a probe definition. Moreover, I'd like to unify the specification of the probe definition with perf-probe. In that case, --probe is more natural. >> Remove caches related to or >> perf cache --remove | >> >> Show all probe caches(including SDT) or buildids >> perf cache --list [probe|buildid] >> >> Delete existing probe-cache entries for kernel, or/and . >> perf cache　--probe-del [:][@][#] > > Ditto, i.e. can't we just use: > > perf cache　--remove [:][@][#] > > And it figure out that this is a probe that is being removed? In most cases, it may be OK, but it is also possible to cause unexpected result when mis-typing. I think if is always starting at '/', it is easy to identify. >> Query the probe definitions. >> perf cache --query [:][@][#] > > Replace --query with --show? OK. Thank you, > >> File Format >> =========== >> All the cache files are placed under ~/.debug/ by default. >> Elf caches are ~/.debug/path/to/file/bu/ildid/elf >> Symbols caches are ~/.debug/path/to/file/bu/ildid/syms >> Probes(and SDT) are ~/.debug/path/to/file/bu/ildid/probes >> And ~/.debug/path/to/file/bu/ildid/ is linked to ~/.debug/.buildid/bu/ildid >> Optionally, we can gzip the probes file. > > Ok! > >> This probe caches contain probe-definitions as following format. >> ---- >> #buildid:BUILDID >> #spec:SDT >> p:sdt_/ PATH:OFFSET [ARGS] >> ... >> #spec:* $params >> p:probe_/ _text+OFFSET [ARGS] >> ... >> ---- >> So the #spec: line gives the information what probe spec has been given. >> This will be used for updating. >> >> And all the "probe_" and "sdt_" prefix will be replaced by % in the command line, >> e.g. >> >> perf record -e %/ -> this records sdt_PROVIDER/EVENT >> >> Thank you, >> >> -- >> Masami HIRAMATSU >> Software Platform Research Dept. Linux Technology Research Center >> Hitachi, Ltd., Yokohama Research Laboratory >> E-mail: masami.hiramatsu.pt@hitachi.com >> > -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Research Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com