From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31254 invoked by alias); 18 Nov 2014 10:32:32 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 31244 invoked by uid 89); 18 Nov 2014 10:32:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail7.hitachi.co.jp Received: from mail7.hitachi.co.jp (HELO mail7.hitachi.co.jp) (133.145.228.42) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 18 Nov 2014 10:32:29 +0000 Received: from mlsv5.hitachi.co.jp (unknown [133.144.234.166]) by mail7.hitachi.co.jp (Postfix) with ESMTP id 78E6B37AC9; Tue, 18 Nov 2014 19:32:27 +0900 (JST) Received: from mfilter05.hitachi.co.jp by mlsv5.hitachi.co.jp (8.13.1/8.13.1) id sAIAWRAB024324; Tue, 18 Nov 2014 19:32:27 +0900 Received: from vshuts04.hitachi.co.jp (vshuts04.hitachi.co.jp [10.201.6.86]) by mfilter05.hitachi.co.jp (Switch-3.3.4/Switch-3.3.4) with ESMTP id sAIAWOeS019987; Tue, 18 Nov 2014 19:32:26 +0900 Received: from gxml20a.ad.clb.hitachi.co.jp (unknown [158.213.157.160]) by vshuts04.hitachi.co.jp (Postfix) with ESMTP id 55CDC14004B; Tue, 18 Nov 2014 19:32:26 +0900 (JST) Received: from [10.198.219.44] by gxml20a.ad.clb.hitachi.co.jp (Switch-3.1.10/Switch-3.1.9) id 6AIA0WQUW00002AD4; Tue, 18 Nov 2014 19:32:26 +0900 Message-ID: <546B2035.2060402@hitachi.com> Date: Tue, 18 Nov 2014 10:32:00 -0000 From: Masami Hiramatsu User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Hemant Kumar , linux-kernel@vger.kernel.org, srikar@linux.vnet.ibm.com, peterz@infradead.org, oleg@redhat.com, hegdevasant@linux.vnet.ibm.com, mingo@redhat.com, systemtap@sourceware.org, aravinda@linux.vnet.ibm.com, penberg@iki.fi, brendan.d.gregg@gmail.com, "yrl.pp-manager.tt@hitachi.com" Subject: Re: Re: [RFC] perf-cache command interface design References: <87lhnr5sbl.fsf@sejong.aot.lge.com> <54588905.7040002@linux.vnet.ibm.com> <5458CD15.4010101@hitachi.com> <874muew2hk.fsf@sejong.aot.lge.com> <5459E865.6050207@hitachi.com> <545B1DDE.9000202@linux.vnet.ibm.com> <545C80F4.4020905@hitachi.com> <54609A8C.4050308@hitachi.com> <20141110122321.GC4468@redhat.com> <5461B276.50004@hitachi.com> <20141111131030.GG4468@redhat.com> <54637C05.5090807@hitachi.com> <87oas6ttf8.fsf@sejong.aot.lge.com> <546968CB.1070802@hitachi.com> <87389hruhn.fsf@sejong.aot.lge.com> In-Reply-To: <87389hruhn.fsf@sejong.aot.lge.com> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2014-q4/txt/msg00156.txt.bz2 (2014/11/18 13:41), Namhyung Kim wrote: > Hi Masami, > > On Mon, 17 Nov 2014 12:17:31 +0900, Masami Hiramatsu wrote: >> (2014/11/17 12:08), Namhyung Kim wrote: >>> I prefer this too. But I'd like make the 'add' part a subcommand rather >>> than option like we do in perf kmem/kvm/list/lock/mem/sched ... And it >>> can handle multiple files at once. What about this? >>> >>> perf cache add [--elf|--sdt|--probe ] [...] >> >> OK, that's good to me. And I think --elf/--sdt is meaningless. > > Maybe not :) > > I'm considering the opposite side - by providing the options, we also > support the negative ones too. So --no-elf and/or --no-sdt options are > possible. Also the positive options can be used with del(ete) > subcommand to remove some contents selectively. > > I think it'd be helpful as we sometimes don't want to do that for some > reason. For example, current perf record adds binary (elf) files to the > cache automatically iff it's accessed. But what about SDTs? Should we > add SDTs at the same time? If not, what if we try to add existing elf > files only for SDTs? Ah, I see. Indeed, in this case we'd better have perf cache add --sdt for explicitly adding SDTs. (Of course perf cache add can also add SDTs automagically, but adding --sdt is more natural) Thank you, -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Research Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com