From: Josh Stone <jistone@redhat.com>
To: systemtap@sourceware.org
Subject: Re: Array handling question
Date: Mon, 20 Jul 2015 19:09:00 -0000 [thread overview]
Message-ID: <55AD477A.9000205@redhat.com> (raw)
In-Reply-To: <55AD3A9F.4030703@linaro.org>
On 07/20/2015 11:14 AM, Zoltan Kiss wrote:
> Hi,
>
> I have troubles to get what I want from linetimes.stp example, so I've
> decided to create my own somewhat simplified version. I'm currently
> interested in the average runtime of a function after a certain number
> of runs, but apparently it gives me values like 74279383992077, which is
> clearly wrong. And I have a feeling I'm misunderstanding something
> obvious about the array handling, but I couldn't figure out what.
> Could anyone give me an advice about what am I missing?
I don't see where you are doing anything with arrays
-- do you mean stats?
> Regards,
>
> Zoltan Kiss
>
> And here is my example script:
>
> global cnt = 0;
> global starttime = 0;
These two are scalar longs.
> global runtimes;
This is a statistic value, thanks to your '<<<' assignment.
> probe process(<procname>).function(<funcname>).call {
> starttime = gettimeofday_ns();
> }
Since starttime is a scalar, this will behave badly if you ever have
multiple calls active at the same time. These could be simultaneous
from separate threads or even just recursive calls in a single thread.
So this is usually where we'd recommend at least a tid()-indexed array,
and probably another nesting index to deal with recursion. But you
don't need to write that manually; stap has @entry for this purpose.
> probe process(<procname>).function(<funcname>).return {
> runtime = gettimeofday_ns() - starttime;
> starttime = 0;
Consider this sequence with two threads, maybe from different processes:
1. Thread A reaches the .call and sets starttime.
2. Thread B reaches the .call and sets a later starttime.
3. Either thread reaches the .return, uses starttime, and sets it to 0.
4. The remaining thread reaches .return and uses gettimeofday_ns - 0.
This is nanoseconds since the Unix epoch, a large value that will skew
your @avg so much to be useless.
Recursion has a similar story, with call-A, call-B, return-B, return-A.
With @entry, you can remove your .call probe and just write:
runtime = gettimeofday(ns) - @entry(gettimeofday_ns())
That will automatically take care of multiple threads and recursion.
> runtimes <<< runtime;
> if (cnt > 50000) {
> printf("Runtime avg: %u\n", @avg(runtimes));
> delete runtimes;
> cnt = 0;
> }
> cnt++;
> }
next prev parent reply other threads:[~2015-07-20 19:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-20 18:15 Zoltan Kiss
2015-07-20 19:09 ` Josh Stone [this message]
2015-07-21 14:23 ` Frank Ch. Eigler
2015-07-31 11:45 ` Zoltan Kiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55AD477A.9000205@redhat.com \
--to=jistone@redhat.com \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).