From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25244 invoked by alias); 6 Aug 2015 01:30:55 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 25170 invoked by uid 89); 6 Aug 2015 01:30:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.3 required=5.0 tests=AWL,BAYES_50,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 06 Aug 2015 01:30:53 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id E6D9A36B1EE; Thu, 6 Aug 2015 01:30:51 +0000 (UTC) Received: from [10.10.48.106] (vpn-48-106.rdu2.redhat.com [10.10.48.106]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t761UpXG031592; Wed, 5 Aug 2015 21:30:51 -0400 Subject: Re: What about MIPS support? To: Crestez Dan Leonard References: <5036AA9A.2010706@redhat.com> <55C204AC.4080106@redhat.com> <55C23910.4060707@redhat.com> Cc: systemtap@sourceware.org From: William Cohen Message-ID: <55C2B8CB.3060700@redhat.com> Date: Thu, 06 Aug 2015 01:30:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/mixed; boundary="------------090901030203010004030500" X-IsSubscribed: yes X-SW-Source: 2015-q3/txt/msg00073.txt.bz2 This is a multi-part message in MIME format. --------------090901030203010004030500 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-length: 866 On 08/05/2015 02:45 PM, Crestez Dan Leonard wrote: > Hello, > > Those patches were on top of an older version. I just rebased on top of latest release 2.8 and only encountered a minor conflict. There are no further conflicts when rebasing on top of latest master. I pushed the branches here: > > https://github.com/cdleonard/systemtap/commits/mips-2.8 > https://github.com/cdleonard/systemtap/commits/mips-master > > Regards, > Leonard Hi Leonard, Thanks for the pointers to current git trees with the patches. I found that the div instruction for the mips processor is not coded correctly and the "make installcheck" smoke test fails as a result. Attached is a patch to fix that and allow the systemtap.base/arith.exp test to pass. With this patch the mips-master branch will run the "make installcheck" testsuite on a 32-bit mips processor -Will --------------090901030203010004030500 Content-Type: text/x-patch; name="mips_div_asm.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="mips_div_asm.patch" Content-length: 948 diff --git a/runtime/linux/arith.c b/runtime/linux/arith.c index 9f65711..9de9bb6 100644 --- a/runtime/linux/arith.c +++ b/runtime/linux/arith.c @@ -252,12 +252,14 @@ typedef union #elif defined (__mips__) -#define umul_ppmm(w1, w0, u, v) \ - __asm__ ("multu %2,%3" \ - : "=l" ((USItype) (w0)), \ - "=h" ((USItype) (w1)) \ - : "d" ((USItype) (u)), \ - "d" ((USItype) (v))) +#define umul_ppmm(w1, w0, u, v) \ + __asm__ ("multu %2,%3\n" \ + "mflo %0\n" \ + "mfhi %1\n" \ + : "=d" ((USItype) (w0)), \ + "=d" ((USItype) (w1)) \ + : "d" ((USItype) (u)), \ + "d" ((USItype) (v))) #if !defined (sub_ddmmss) #define sub_ddmmss(sh, sl, ah, al, bh, bl) \ --------------090901030203010004030500--