Re: [RFC] Enhanced Garbage Collection Probe Points

[Andrew Hughes <gnu.andrew@redhat.com>]

----- Original Message -----
> 
> 
> ----- Original Message -----
> > From: "Lukas Berk" <lberk@redhat.com>
> > To: "Jon VanAlten" <jvanalte@redhat.com>
> > Cc: systemtap@sourceware.org, distro-pkg-dev@openjdk.java.net
> > Sent: Tuesday, October 23, 2012 12:53:30 PM
> > Subject: Re: [RFC] Enhanced Garbage Collection Probe Points
> > 
> > Hey,
> > 
> > * Jon VanAlten <jvanalte@redhat.com> [2012-09-24 14:16]:
> > > 
> > > > 
> > > > > > Is this ok to commit?
> > > > > > 
> > > > > 
> > > > > With caveats noted above, I say yes :)
> > > > > 
> > > > 
> > > > Thanks! Please let me know if there is anything else you'd like
> > > > to
> > > > know,
> > > > updated patch is attached.
> > > > 
> > > 
> > > Hi,
> > > 
> > > This has been in my TODO for some time, so I am very sorry not to
> > > have responded earlier.  From looking at the patch, it seems okay
> > > now.  I intend to push this to HEAD on your behalf, unless
> > > someone
> > > else has some reason why not.  (Now is your chance to speak up
> > > about that, if you have such a reason!).  But, I do feel
> > > responsible
> > > to build with it myself and verify that things seem to be working
> > > as
> > > intended.  Various other things have been jumping my work queue,
> > > but
> > > I may have time this week to give this a sanity check and finally
> > > get it into hg.  Thanks for persisting!
> > > 
> > > cheers,
> > > Jon
> > 
> > I've updated the patch slightly to reflect a correction in
> > psScavenge.cpp that was causing a build error when icedtea-debug
> > wasn't
> > specified.  The rest of the patch is unchanged from before.
> > 
> 
> And I've now pushed this.  I know it's preferred that new work
> goes to forest in general, but this was discussed earlier when
> patch was originally posted, and afaict the feeling was it
> would be better to move all systemtap related patches there in
> one step some time later[1].
> 
> Thanks Lukas for this contribution!
> 

Why has this been pushed?  We don't want more patches adding to IcedTea7.
Please revert.

> cheers,
> jon
> 
> [1]
> http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2012-August/020066.html
> 

-- 
Andrew :)

Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

PGP Key: 248BDC07 (https://keys.indymedia.org/)
Fingerprint = EC5A 1F5E C0AD 1D15 8F1F  8F91 3B96 A578 248B DC07