From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 22516 invoked by alias); 25 Oct 2012 13:09:11 -0000 Received: (qmail 22499 invoked by uid 22791); 25 Oct 2012 13:09:11 -0000 X-SWARE-Spam-Status: No, hits=-5.2 required=5.0 tests=AWL,BAYES_00,KHOP_RCVD_UNTRUST,KHOP_THREADED,RCVD_IN_DNSWL_HI,RCVD_IN_HOSTKARMA_W,RP_MATCHES_RCVD,SPF_HELO_PASS X-Spam-Check-By: sourceware.org Received: from mx3-phx2.redhat.com (HELO mx3-phx2.redhat.com) (209.132.183.24) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 25 Oct 2012 13:09:00 +0000 Received: from zmail17.collab.prod.int.phx2.redhat.com (zmail17.collab.prod.int.phx2.redhat.com [10.5.83.19]) by mx3-phx2.redhat.com (8.13.8/8.13.8) with ESMTP id q9PD8xta009213; Thu, 25 Oct 2012 09:08:59 -0400 Date: Thu, 25 Oct 2012 13:09:00 -0000 From: Andrew Hughes To: Jon VanAlten Cc: systemtap@sourceware.org, distro-pkg-dev@openjdk.java.net, Lukas Berk Message-ID: <561523661.6232111.1351170539693.JavaMail.root@redhat.com> In-Reply-To: <480767885.1600415.1351141329748.JavaMail.root@redhat.com> Subject: Re: [RFC] Enhanced Garbage Collection Probe Points MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2012-q4/txt/msg00130.txt.bz2 ----- Original Message ----- > > > ----- Original Message ----- > > From: "Lukas Berk" > > To: "Jon VanAlten" > > Cc: systemtap@sourceware.org, distro-pkg-dev@openjdk.java.net > > Sent: Tuesday, October 23, 2012 12:53:30 PM > > Subject: Re: [RFC] Enhanced Garbage Collection Probe Points > > > > Hey, > > > > * Jon VanAlten [2012-09-24 14:16]: > > > > > > > > > > > > > Is this ok to commit? > > > > > > > > > > > > > > > > With caveats noted above, I say yes :) > > > > > > > > > > > > > Thanks! Please let me know if there is anything else you'd like > > > > to > > > > know, > > > > updated patch is attached. > > > > > > > > > > Hi, > > > > > > This has been in my TODO for some time, so I am very sorry not to > > > have responded earlier. From looking at the patch, it seems okay > > > now. I intend to push this to HEAD on your behalf, unless > > > someone > > > else has some reason why not. (Now is your chance to speak up > > > about that, if you have such a reason!). But, I do feel > > > responsible > > > to build with it myself and verify that things seem to be working > > > as > > > intended. Various other things have been jumping my work queue, > > > but > > > I may have time this week to give this a sanity check and finally > > > get it into hg. Thanks for persisting! > > > > > > cheers, > > > Jon > > > > I've updated the patch slightly to reflect a correction in > > psScavenge.cpp that was causing a build error when icedtea-debug > > wasn't > > specified. The rest of the patch is unchanged from before. > > > > And I've now pushed this. I know it's preferred that new work > goes to forest in general, but this was discussed earlier when > patch was originally posted, and afaict the feeling was it > would be better to move all systemtap related patches there in > one step some time later[1]. > > Thanks Lukas for this contribution! > Why has this been pushed? We don't want more patches adding to IcedTea7. Please revert. > cheers, > jon > > [1] > http://mail.openjdk.java.net/pipermail/distro-pkg-dev/2012-August/020066.html > -- Andrew :) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) PGP Key: 248BDC07 (https://keys.indymedia.org/) Fingerprint = EC5A 1F5E C0AD 1D15 8F1F 8F91 3B96 A578 248B DC07