From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 35010 invoked by alias); 22 Oct 2015 16:34:10 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 35002 invoked by uid 89); 22 Oct 2015 16:34:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 22 Oct 2015 16:34:08 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (Postfix) with ESMTPS id 68055CE1; Thu, 22 Oct 2015 16:34:07 +0000 (UTC) Received: from t540p.usersys.redhat.com (unused [10.10.51.8] (may be forged)) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id t9MGY46M023490 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 22 Oct 2015 12:34:06 -0400 Subject: Re: [PATCH 1/1] stp: rt: replace spin_lock with stp style lock and use STP_ALLOC_FLAGS To: Zhu Yanjun , systemtap@sourceware.org References: <1445499965-23777-1-git-send-email-yanjun.zhu@windriver.com> From: David Smith Message-ID: <56290FFC.3030407@redhat.com> Date: Thu, 22 Oct 2015 16:34:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1445499965-23777-1-git-send-email-yanjun.zhu@windriver.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-q4/txt/msg00046.txt.bz2 On 10/22/2015 02:46 AM, Zhu Yanjun wrote: > -rt mode spin lock lead to __might_sleep calltrace. > Replacing spin lock with stp type raw lock and > changing STP_ALLOC_SLEEP_FLAGS to STP_ALLOC_FLAGS solves the problem. In general, this patch looks fine. However, I'm not too sure about the STP_ALLOC_SLEEP_FLAGS bit. Can show us a backtrace that happens with your spinlock changes but without the alloc flags changes or explain why the alloc flags change is necessary? It could be that we're using the wrong set of flags in the caller. Thanks. -- David Smith dsmith@redhat.com Red Hat http://www.redhat.com 256.217.0141 (direct) 256.837.0057 (fax)