From: yzhu1 <Yanjun.Zhu@windriver.com>
To: David Smith <dsmith@redhat.com>, <systemtap@sourceware.org>
Subject: Re: [PATCH 1/1] stp: rt: replace spin_lock with stp style lock and use STP_ALLOC_FLAGS
Date: Mon, 26 Oct 2015 03:19:00 -0000 [thread overview]
Message-ID: <562D9BAA.7040704@windriver.com> (raw)
In-Reply-To: <56290FFC.3030407@redhat.com>
Hi, David
I do not have this backtrace. Because STP_ALLOC_SLEEP_FLAGS will cause
kmalloc sleep,
so I replaced it with STP_ALLOC_FLAGS.
Zhu Yanjun
On 10/23/2015 12:34 AM, David Smith wrote:
> On 10/22/2015 02:46 AM, Zhu Yanjun wrote:
>> -rt mode spin lock lead to __might_sleep calltrace.
>> Replacing spin lock with stp type raw lock and
>> changing STP_ALLOC_SLEEP_FLAGS to STP_ALLOC_FLAGS solves the problem.
> In general, this patch looks fine. However, I'm not too sure about the
> STP_ALLOC_SLEEP_FLAGS bit. Can show us a backtrace that happens with
> your spinlock changes but without the alloc flags changes or explain why
> the alloc flags change is necessary? It could be that we're using the
> wrong set of flags in the caller.
>
> Thanks.
>
next prev parent reply other threads:[~2015-10-26 3:19 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-22 7:45 Zhu Yanjun
2015-10-22 7:53 ` yzhu1
2015-10-23 4:04 ` Santosh Shukla
2015-10-26 7:03 ` yzhu1
2015-10-26 8:25 ` yzhu1
2015-10-26 8:43 ` Santosh Shukla
2015-11-17 7:38 ` yzhu1
2015-11-17 7:52 ` Santosh Shukla
2015-10-22 16:34 ` David Smith
2015-10-26 3:19 ` yzhu1 [this message]
2015-10-26 21:28 ` David Smith
2015-10-27 13:52 ` Frank Ch. Eigler
2015-10-28 2:30 ` yzhu1
2015-10-28 17:09 ` David Smith
2015-11-17 8:09 stp: rt: replace spin_lock with stp style lock and use yzhu1
2015-11-17 8:09 ` [PATCH 1/1] stp: rt: replace spin_lock with stp style lock and use STP_ALLOC_FLAGS yzhu1
2015-11-17 16:45 ` David Smith
2015-11-18 8:14 ` yzhu1
2015-11-18 17:14 ` David Smith
2015-11-19 7:53 ` yzhu1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=562D9BAA.7040704@windriver.com \
--to=yanjun.zhu@windriver.com \
--cc=dsmith@redhat.com \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).