From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 105576 invoked by alias); 26 Oct 2015 03:19:13 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 105563 invoked by uid 89); 26 Oct 2015 03:19:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.8 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mail1.windriver.com Received: from mail1.windriver.com (HELO mail1.windriver.com) (147.11.146.13) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-SHA encrypted) ESMTPS; Mon, 26 Oct 2015 03:19:11 +0000 Received: from ALA-HCA.corp.ad.wrs.com (ala-hca.corp.ad.wrs.com [147.11.189.40]) by mail1.windriver.com (8.15.2/8.15.1) with ESMTPS id t9Q3J6iV018971 (version=TLSv1 cipher=AES128-SHA bits=128 verify=FAIL); Sun, 25 Oct 2015 20:19:07 -0700 (PDT) Received: from [128.224.162.133] (128.224.162.133) by ALA-HCA.corp.ad.wrs.com (147.11.189.50) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 25 Oct 2015 20:19:06 -0700 Subject: Re: [PATCH 1/1] stp: rt: replace spin_lock with stp style lock and use STP_ALLOC_FLAGS To: David Smith , References: <1445499965-23777-1-git-send-email-yanjun.zhu@windriver.com> <56290FFC.3030407@redhat.com> From: yzhu1 Message-ID: <562D9BAA.7040704@windriver.com> Date: Mon, 26 Oct 2015 03:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:38.0) Gecko/20100101 Thunderbird/38.2.0 MIME-Version: 1.0 In-Reply-To: <56290FFC.3030407@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-q4/txt/msg00055.txt.bz2 Hi, David I do not have this backtrace. Because STP_ALLOC_SLEEP_FLAGS will cause kmalloc sleep, so I replaced it with STP_ALLOC_FLAGS. Zhu Yanjun On 10/23/2015 12:34 AM, David Smith wrote: > On 10/22/2015 02:46 AM, Zhu Yanjun wrote: >> -rt mode spin lock lead to __might_sleep calltrace. >> Replacing spin lock with stp type raw lock and >> changing STP_ALLOC_SLEEP_FLAGS to STP_ALLOC_FLAGS solves the problem. > In general, this patch looks fine. However, I'm not too sure about the > STP_ALLOC_SLEEP_FLAGS bit. Can show us a backtrace that happens with > your spinlock changes but without the alloc flags changes or explain why > the alloc flags change is necessary? It could be that we're using the > wrong set of flags in the caller. > > Thanks. >