From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103111 invoked by alias); 9 Nov 2015 21:24:45 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 103079 invoked by uid 89); 9 Nov 2015 21:24:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 09 Nov 2015 21:24:36 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id B110E8E233; Mon, 9 Nov 2015 21:24:35 +0000 (UTC) Received: from t540p.usersys.redhat.com (vpn-55-86.rdu2.redhat.com [10.10.55.86]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tA9LOXpA019746 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 9 Nov 2015 16:24:34 -0500 Subject: Re: [PATCH 1/3] add testcases for function definitions To: Josh Stone , Zhou Wenjian , systemtap@sourceware.org References: <1447059456-19811-1-git-send-email-zhouwj-fnst@cn.fujitsu.com> <5640E0EE.2060803@redhat.com> From: David Smith Message-ID: <56410F10.20104@redhat.com> Date: Mon, 09 Nov 2015 21:24:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5640E0EE.2060803@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-q4/txt/msg00099.txt.bz2 On 11/09/2015 12:07 PM, Josh Stone wrote: > On 11/09/2015 12:57 AM, Zhou Wenjian wrote: >> +foreach runtime [get_runtime_list] { >> + if {$runtime != ""} { >> + stap_run $srcdir/$subdir/$test.stp no_load ${all_pass_string}${all_pass_string}${all_pass_string}${all_pass_string}${all_pass_string} \ >> + --runtime=$runtime >> + } else { >> + stap_run $srcdir/$subdir/$test.stp no_load ${all_pass_string}${all_pass_string}${all_pass_string}${all_pass_string}${all_pass_string} >> + } >> +} > > I disagree with using repetition like this for "exact" results. The > string already has regex repetition built in: > > set all_pass_string "(systemtap test success\r\n)+" Ah, I didn't know it did that. > '+' means match one or more, greedily. Repeating this expression on top > of itself creates a bad case for the regex engine to backtrack. > (It will work, but slowly.) Hmm, having repetitions of the all_pass_string *should* work, but doesn't. My guess would be that this used to work on older versions of tcl/expect, but doesn't work now. The end-of-line handling has always been iffy in tcl/expect. > IMO we ought to make stap_run ensure nothing comes *after* the expected > output string. If there are tests that are legitimately printing more > output, those are the ones we should be fixing. That's a good idea. I'll try to look into it in the near future. > Maybe we could also add the string without repetition, something like: > > set pass_string "systemtap test success\r\n" > set all_pass_string "($pass_string)+" > > Then you can use "($pass_string){5}" if you really want exactly 5 > matches. But stap_run should still make sure nothing comes after that. > > -- David Smith dsmith@redhat.com Red Hat http://www.redhat.com 256.217.0141 (direct) 256.837.0057 (fax)