From: David Smith <dsmith@redhat.com>
To: yzhu1 <yanjun.zhu@windriver.com>,
sshukla@mvista.com, systemtap@sourceware.org
Subject: Re: [PATCH 1/1] stp: rt: replace spin_lock with stp style lock and use STP_ALLOC_FLAGS
Date: Tue, 17 Nov 2015 16:45:00 -0000 [thread overview]
Message-ID: <564B599D.3000506@redhat.com> (raw)
In-Reply-To: <1447747786-29733-2-git-send-email-yanjun.zhu@windriver.com>
On 11/17/2015 02:09 AM, yzhu1 wrote:
> From: Zhu Yanjun <yanjun.zhu@windriver.com>
>
> -rt mode spin lock lead to __might_sleep calltrace.
> Replacing spin lock with stp type raw lock and
> changing STP_ALLOC_SLEEP_FLAGS to STP_ALLOC_FLAGS solves the problem.
I have the same comment I had before. The raw lock changes are fine, but
I still don't believe the STP_ALLOC_SLEEP_FLAGS change is correct, at
least not without some further explanation. In the call trace below,
STP_ALLOC_SLEEP_FLAGS wasn't used from what I can tell.
Did you get a chance to try running systemtap with your raw lock changes
and the added might_sleep() call patch I sent you?
> Call Trace:
> [<ffffffff818d83f1>] dump_stack+0x19/0x1b
> [<ffffffff81070e3f>] __might_sleep+0xef/0x160
> [<ffffffff818de710>] rt_spin_lock+0x20/0x50
> [<ffffffff81178699>] d_path+0x79/0x1a0
> [<ffffffffa0047be9>] __stp_get_mm_path.constprop.79+0x49/0x90 [stap_f5bb3e3c9b162aab5a51afc2375fe9cf_2073]
> [<ffffffffa004d01b>] __stp_utrace_attach_match_tsk.isra.53+0x7b/0x1b0 [stap_f5bb3e3c9b162aab5a51afc2375fe9cf_2073]
> [<ffffffffa004d18c>] __stp_utrace_task_finder_report_exec+0x3c/0x50 [stap_f5bb3e3c9b162aab5a51afc2375fe9cf_2073]
> [<ffffffffa0047b59>] utrace_report_exec+0xb9/0x100 [stap_f5bb3e3c9b162aab5a51afc2375fe9cf_2073]
> [<ffffffff811674b2>] search_binary_handler+0x332/0x380
> [<ffffffff81168d0c>] do_execve_common.isra.24+0x55c/0x640
> [<ffffffff81168e08>] do_execve+0x18/0x20
> [<ffffffff81169082>] SyS_execve+0x32/0x50
> [<ffffffff818e6979>] stub_execve+0x69/0xa0
--
David Smith
dsmith@redhat.com
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)
next prev parent reply other threads:[~2015-11-17 16:45 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-17 8:09 stp: rt: replace spin_lock with stp style lock and use yzhu1
2015-11-17 8:09 ` [PATCH 1/1] stp: rt: replace spin_lock with stp style lock and use STP_ALLOC_FLAGS yzhu1
2015-11-17 16:45 ` David Smith [this message]
2015-11-18 8:14 ` yzhu1
2015-11-18 17:14 ` David Smith
2015-11-19 7:53 ` yzhu1
-- strict thread matches above, loose matches on Subject: below --
2015-10-22 7:45 Zhu Yanjun
2015-10-22 7:53 ` yzhu1
2015-10-23 4:04 ` Santosh Shukla
2015-10-26 7:03 ` yzhu1
2015-10-26 8:25 ` yzhu1
2015-10-26 8:43 ` Santosh Shukla
2015-11-17 7:38 ` yzhu1
2015-11-17 7:52 ` Santosh Shukla
2015-10-22 16:34 ` David Smith
2015-10-26 3:19 ` yzhu1
2015-10-26 21:28 ` David Smith
2015-10-27 13:52 ` Frank Ch. Eigler
2015-10-28 2:30 ` yzhu1
2015-10-28 17:09 ` David Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=564B599D.3000506@redhat.com \
--to=dsmith@redhat.com \
--cc=sshukla@mvista.com \
--cc=systemtap@sourceware.org \
--cc=yanjun.zhu@windriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).