From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 94676 invoked by alias); 17 Nov 2015 16:45:24 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 94658 invoked by uid 89); 17 Nov 2015 16:45:22 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Tue, 17 Nov 2015 16:45:21 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) by mx1.redhat.com (Postfix) with ESMTPS id 4434DC10045D; Tue, 17 Nov 2015 16:45:20 +0000 (UTC) Received: from t540p.usersys.redhat.com (vpn-61-162.rdu2.redhat.com [10.10.61.162]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tAHGjHjZ000943 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Tue, 17 Nov 2015 11:45:19 -0500 Subject: Re: [PATCH 1/1] stp: rt: replace spin_lock with stp style lock and use STP_ALLOC_FLAGS To: yzhu1 , sshukla@mvista.com, systemtap@sourceware.org References: <1447747786-29733-1-git-send-email-yanjun.zhu@windriver.com> <1447747786-29733-2-git-send-email-yanjun.zhu@windriver.com> From: David Smith Message-ID: <564B599D.3000506@redhat.com> Date: Tue, 17 Nov 2015 16:45:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <1447747786-29733-2-git-send-email-yanjun.zhu@windriver.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2015-q4/txt/msg00141.txt.bz2 On 11/17/2015 02:09 AM, yzhu1 wrote: > From: Zhu Yanjun > > -rt mode spin lock lead to __might_sleep calltrace. > Replacing spin lock with stp type raw lock and > changing STP_ALLOC_SLEEP_FLAGS to STP_ALLOC_FLAGS solves the problem. I have the same comment I had before. The raw lock changes are fine, but I still don't believe the STP_ALLOC_SLEEP_FLAGS change is correct, at least not without some further explanation. In the call trace below, STP_ALLOC_SLEEP_FLAGS wasn't used from what I can tell. Did you get a chance to try running systemtap with your raw lock changes and the added might_sleep() call patch I sent you? > Call Trace: > [] dump_stack+0x19/0x1b > [] __might_sleep+0xef/0x160 > [] rt_spin_lock+0x20/0x50 > [] d_path+0x79/0x1a0 > [] __stp_get_mm_path.constprop.79+0x49/0x90 [stap_f5bb3e3c9b162aab5a51afc2375fe9cf_2073] > [] __stp_utrace_attach_match_tsk.isra.53+0x7b/0x1b0 [stap_f5bb3e3c9b162aab5a51afc2375fe9cf_2073] > [] __stp_utrace_task_finder_report_exec+0x3c/0x50 [stap_f5bb3e3c9b162aab5a51afc2375fe9cf_2073] > [] utrace_report_exec+0xb9/0x100 [stap_f5bb3e3c9b162aab5a51afc2375fe9cf_2073] > [] search_binary_handler+0x332/0x380 > [] do_execve_common.isra.24+0x55c/0x640 > [] do_execve+0x18/0x20 > [] SyS_execve+0x32/0x50 > [] stub_execve+0x69/0xa0 -- David Smith dsmith@redhat.com Red Hat http://www.redhat.com 256.217.0141 (direct) 256.837.0057 (fax)