From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61478 invoked by alias); 30 Nov 2015 21:49:01 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 61454 invoked by uid 89); 30 Nov 2015 21:49:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.8 required=5.0 tests=AWL,BAYES_00,BODY_8BITS,GARBLED_BODY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 30 Nov 2015 21:48:59 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (Postfix) with ESMTPS id 91A00C0D2241; Mon, 30 Nov 2015 21:48:58 +0000 (UTC) Received: from t540p.usersys.redhat.com (dhcp-10-15-1-6.hsv.redhat.com [10.15.1.6]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tAULmvhK022248 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 30 Nov 2015 16:48:57 -0500 Subject: Re: [PATCH 1/4] add case for probe timer To: =?UTF-8?B?WmhvdSwgV2Vuamlhbi/lkajmlofliZE=?= , "Frank Ch. Eigler" References: <1447406704-14585-1-git-send-email-zhouwj-fnst@cn.fujitsu.com> <5656C888.3080503@cn.fujitsu.com> Cc: systemtap@sourceware.org From: David Smith Message-ID: <565CC449.1070401@redhat.com> Date: Mon, 30 Nov 2015 21:49:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.3.0 MIME-Version: 1.0 In-Reply-To: <5656C888.3080503@cn.fujitsu.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2015-q4/txt/msg00202.txt.bz2 On 11/26/2015 02:53 AM, "Zhou, Wenjian/周文剑" wrote: > Hello Frank and David, > > I try to send essential cases, but I can't make sure all of the cases > are needed. > So I need your help. If you have time, you can tell me why the cases have > no sense, or you can just let me know which are meaningless. > Both will help me a lot. I can't really speak for Frank, but I took a further look at the testcases. Here's what I found: PATCH 1/4 (timer testcase): Checked in PATCH 2/4 (conditional compile): This testcase looks like it tests the same things as testsuite/systemtap.base/preprocessor.exp. If you feel like your testcase found something that one doesn't, we can add new subtests to preprocessor.exp. PATCH 3/4 (add cases for var definition): Checked in. PATCH 4/4 (add cases for var type): This one looks very similar to testsuite/semko/typedefinition.stp. Once again if you feel like your testcase found something this one doesn't, we can add new subtests to typedefinition.exp. Thanks again for the tests. -- David Smith dsmith@redhat.com Red Hat http://www.redhat.com 256.217.0141 (direct) 256.837.0057 (fax)