From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 34313 invoked by alias); 1 Dec 2015 02:11:00 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 34300 invoked by uid 89); 1 Dec 2015 02:10:59 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: Yes, score=5.8 required=5.0 tests=AWL,BAYES_50,BODY_8BITS,GARBLED_BODY,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: heian.cn.fujitsu.com Received: from cn.fujitsu.com (HELO heian.cn.fujitsu.com) (59.151.112.132) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Dec 2015 02:10:59 +0000 Received: from bogon (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 01 Dec 2015 10:10:43 +0800 Received: from G08CNEXCHPEKD02.g08.fujitsu.local (unknown [10.167.33.83]) by cn.fujitsu.com (Postfix) with ESMTP id 8B4044092576; Tue, 1 Dec 2015 10:10:38 +0800 (CST) Received: from localhost.localdomain (10.167.226.48) by G08CNEXCHPEKD02.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server id 14.3.181.6; Tue, 1 Dec 2015 10:10:38 +0800 Message-ID: <565D0153.4030405@cn.fujitsu.com> Date: Tue, 01 Dec 2015 02:11:00 -0000 From: =?UTF-8?B?Ilpob3UsIFdlbmppYW4v5ZGo5paH5YmRIg==?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: David Smith CC: Subject: Re: [PATCH 1/4] add case for probe timer References: <1447406704-14585-1-git-send-email-zhouwj-fnst@cn.fujitsu.com> <5656C888.3080503@cn.fujitsu.com> <565CC449.1070401@redhat.com> In-Reply-To: <565CC449.1070401@redhat.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit X-yoursite-MailScanner-Information: Please contact the ISP for more information X-yoursite-MailScanner-ID: 8B4044092576.A8FFB X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: zhouwj-fnst@cn.fujitsu.com X-IsSubscribed: yes X-SW-Source: 2015-q4/txt/msg00208.txt.bz2 On 12/01/2015 05:48 AM, David Smith wrote: > On 11/26/2015 02:53 AM, "Zhou, Wenjian/周文剑" wrote: >> Hello Frank and David, >> >> I try to send essential cases, but I can't make sure all of the cases >> are needed. >> So I need your help. If you have time, you can tell me why the cases have >> no sense, or you can just let me know which are meaningless. >> Both will help me a lot. > > I can't really speak for Frank, but I took a further look at the > testcases. Here's what I found: > > PATCH 1/4 (timer testcase): Checked in > > PATCH 2/4 (conditional compile): This testcase looks like it tests the > same things as testsuite/systemtap.base/preprocessor.exp. If you feel > like your testcase found something that one doesn't, we can add new > subtests to preprocessor.exp. > Thanks a lot for pointing it out. > PATCH 3/4 (add cases for var definition): Checked in. > > PATCH 4/4 (add cases for var type): This one looks very similar to > testsuite/semko/typedefinition.stp. Once again if you feel like your > testcase found something this one doesn't, we can add new subtests to > typedefinition.exp. > I reviewed the typedefinition.stp and I found that it can't work as expected. So I rewrite it. I will describe it exactly following the rewriting patch. > Thanks again for the tests. > -- Thanks Zhou