From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86956 invoked by alias); 1 Dec 2015 02:57:17 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 86823 invoked by uid 89); 1 Dec 2015 02:56:56 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.6 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: heian.cn.fujitsu.com Received: from cn.fujitsu.com (HELO heian.cn.fujitsu.com) (59.151.112.132) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Dec 2015 02:56:55 +0000 Received: from bogon (HELO cn.fujitsu.com) ([10.167.33.5]) by heian.cn.fujitsu.com with ESMTP; 01 Dec 2015 10:56:40 +0800 Received: from G08CNEXCHPEKD02.g08.fujitsu.local (unknown [10.167.33.83]) by cn.fujitsu.com (Postfix) with ESMTP id 0BCBE4092567; Tue, 1 Dec 2015 10:56:35 +0800 (CST) Received: from localhost.localdomain (10.167.226.48) by G08CNEXCHPEKD02.g08.fujitsu.local (10.167.33.89) with Microsoft SMTP Server id 14.3.181.6; Tue, 1 Dec 2015 10:56:34 +0800 Message-ID: <565D0C18.7060902@cn.fujitsu.com> Date: Tue, 01 Dec 2015 02:57:00 -0000 From: =?UTF-8?B?Ilpob3UsIFdlbmppYW4v5ZGo5paH5YmRIg==?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: "Frank Ch. Eigler" CC: David Smith , Subject: Re: [PATCH 1/4] add case for probe timer References: <1447406704-14585-1-git-send-email-zhouwj-fnst@cn.fujitsu.com> <5656C888.3080503@cn.fujitsu.com> <20151130223716.GK23121@redhat.com> In-Reply-To: <20151130223716.GK23121@redhat.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-yoursite-MailScanner-Information: Please contact the ISP for more information X-yoursite-MailScanner-ID: 0BCBE4092567.A08C4 X-yoursite-MailScanner: Found to be clean X-yoursite-MailScanner-From: zhouwj-fnst@cn.fujitsu.com X-IsSubscribed: yes X-SW-Source: 2015-q4/txt/msg00210.txt.bz2 On 12/01/2015 06:37 AM, Frank Ch. Eigler wrote: > Hi - > >> I try to send essential cases, but I can't make sure all of the cases >> are needed. >> So I need your help. If you have time, you can tell me why the cases have >> no sense, or you can just let me know which are meaningless. > > The general idea is to check for duplication. If you are testing a > language control flow construct, see if there is already ample usage > of that same construct already in the testsuite. If you are testing a > probe point, see if that same point, or a close member of the family, > is already well-represented. The other idea is that for new tests for > fairly old/static parts of code are probably not worth much effort, > that code having been proven over time. > > For example, the cond_compile test is thoroughly covered already by > other stuff; check all the %( %) preprocessor usage in the tapsets as > well as other testsuite script. The semko ones don't look too > duplicative, but also don't relate to recently-changed code. I > wouldn't oppose those going into the testsuite, but the slight extra > cost of making the test runs longer counts slightly against them. > Thanks a lot for your detailed description. I got that and I will try my best to avoid the duplicate cases. But at one point, I have some different ideas. I don't think the cases should only focus on the recently-changed code. The cases should make sure that the code can work as expected. If we only focus on the recently-changed code, I don't think the testsuite can do much more help than just reviewing the changed code by eyes . -- Thanks Zhou