From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83335 invoked by alias); 9 Dec 2015 21:40:03 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 83326 invoked by uid 89); 9 Dec 2015 21:40:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=0.9 required=5.0 tests=AWL,BAYES_00,BODY_8BITS,GARBLED_BODY,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 09 Dec 2015 21:40:02 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 39FD3689; Wed, 9 Dec 2015 21:40:01 +0000 (UTC) Received: from t540p.usersys.redhat.com (vpn-54-42.rdu2.redhat.com [10.10.54.42]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id tB9LdwrZ021265 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 9 Dec 2015 16:40:00 -0500 Subject: Re: [PATCH 1/3] add test cases for arith To: =?UTF-8?B?WmhvdSwgV2Vuamlhbi/lkajmlofliZE=?= , "Frank Ch. Eigler" References: <1449479119-10817-1-git-send-email-zhouwj-fnst@cn.fujitsu.com> <5667F74D.2090305@cn.fujitsu.com> Cc: systemtap@sourceware.org From: David Smith Message-ID: <56689FAE.5090101@redhat.com> Date: Wed, 09 Dec 2015 21:40:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.4.0 MIME-Version: 1.0 In-Reply-To: <5667F74D.2090305@cn.fujitsu.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-IsSubscribed: yes X-SW-Source: 2015-q4/txt/msg00253.txt.bz2 On 12/09/2015 03:41 AM, "Zhou, Wenjian/周文剑" wrote: > On 12/08/2015 11:09 PM, Frank Ch. Eigler wrote: >> >> Hi - >> >> >> Zhou Wenjian writes: >> >>> * testsuite/systemtap.base/arith.stp: add more cases >>> [...] >> >> I see nothing wrong with the proposed tests, but they seem to add very >> little new coverage to the sorts of things thoroughly exercised >> elsewhere. This set of arith.stp operator tests are probably OK, just >> because we have their siblings there, but whitespace.stp IMHO doesn't >> do anything special. >> > > Hi Frank, > > The whitespace.stp tests that if the systemtap works well with white space > and null statement(";"). > If you think it is not needed, I won't insist. I've checked in the arith and map delete test changes. Thanks! -- David Smith dsmith@redhat.com Red Hat http://www.redhat.com 256.217.0141 (direct) 256.837.0057 (fax)