From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88779 invoked by alias); 13 Apr 2016 15:13:44 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 88709 invoked by uid 89); 13 Apr 2016 15:13:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*f:sk:570D184, H*i:sk:570D184, H*MI:sk:570D184, protect X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 13 Apr 2016 15:13:33 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 26066C04B30D; Wed, 13 Apr 2016 15:13:31 +0000 (UTC) Received: from t540p.usersys.redhat.com (ovpn-116-26.rdu2.redhat.com [10.10.116.26]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u3DFDUTO014550 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 13 Apr 2016 11:13:31 -0400 Subject: Re: Blacklist regex is too general To: Alexander Lochmann , systemtap@sourceware.org References: <570CBC09.2080608@tu-dortmund.de> <570D1745.90506@redhat.com> <570D1846.2060109@tu-dortmund.de> From: David Smith Message-ID: <570E6219.2090608@redhat.com> Date: Wed, 13 Apr 2016 15:13:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.7.1 MIME-Version: 1.0 In-Reply-To: <570D1846.2060109@tu-dortmund.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-q2/txt/msg00033.txt.bz2 On 04/12/2016 10:46 AM, Alexander Lochmann wrote: > On 04/12/2016 05:41 PM, David Smith wrote: >> On 04/12/2016 04:12 AM, Alexander Lochmann wrote: >>> Hi folks! >>> >>> I've wanted to measure the impact of packet duplication due to a raw socket. >>> To do so, I have to probe the kernel function 'raw_v4_input' in >>> net/ipv4/raw.c. >>> Unfortunately, the function name matches the regex defined at >>> dwflpp:4324, which is: blfn += "|raw_.*";. >>> On my opinion, the regex is too general, and there is no reason why it >>> shouldn't be allowed to probe 'raw_v4_input'. >>> It therefore might be necessary to rephrase the mentioned regex. :) >> >> While we think about the best way to proceed here, you should be able to >> use '-g' (guru mode) to ignore the blacklist. >> > Ah. Thx. Good to know. :) > Since I compile my own version, I simply commented that line out. I went through several kernels trying to figure out what that blacklist regular expression was supposed to protect us against, and couldn't find anything. So, commit 0748ca7 removes that regexp. Thanks for the report. -- David Smith dsmith@redhat.com Red Hat http://www.redhat.com 256.217.0141 (direct) 256.837.0057 (fax)