From: Alexander Lochmann <alexander.lochmann@tu-dortmund.de>
To: "Frank Ch. Eigler" <fche@redhat.com>
Cc: Josh Stone <jistone@redhat.com>, systemtap@sourceware.org
Subject: Re: SystemTap for Android - patchset
Date: Wed, 06 Jul 2016 20:27:00 -0000 [thread overview]
Message-ID: <577D6996.40304@tu-dortmund.de> (raw)
In-Reply-To: <20160706201514.GA29337@redhat.com>
[-- Attachment #1.1: Type: text/plain, Size: 1435 bytes --]
On 06.07.2016 22:15, Frank Ch. Eigler wrote:
> Hi -
>
> On Wed, Jul 06, 2016 at 10:05:23PM +0200, Alexander Lochmann wrote:
>> [...]
>>> % sh pidwrapper /path/to/this.pid staprun foo bar baz
>>>
>> That would be a nice workaround. I went through the source code. The
>> commandline option is used by stapio. Stapio creates the pidfile. If I
>> send a SIGKILL (or was it a SIGTERM? what so ever) to staprun, stap and
>> the module won't be shutdown properly. Hence, I have to send the signal
>> to stapio.
>
> Since staprun exec's stapio, the latter will also share the same pid.
> So this wrapper would work, whichever process happens to be running at
> the moment. (Send SIGTERM or SIGINT for a clean shutdown.)
>
Indeed... strange. If I remember it correctly, I would say that wasn't
the case in that past. But git blame says something different.
Thus, I suppose it was my "fault". I thing I simply misinterpreted my
observations with "ps aux" back in that days. Anyway, I'll try your bash
wrapper. :-)
Do you have any concerns about the rest of my Android patch?
Namely the build script and those ifdefs in staprun.c.
- Alex
>
> - FChE
>
--
Technische Universität Dortmund
Alexander Lochmann PGP key: 0xBC3EF6FD
Otto-Hahn-Str. 16 phone: +49.231.7556141
D-44227 Dortmund fax: +49.231.7556116
http://ess.cs.tu-dortmund.de/Staff/al
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2016-07-06 20:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <f01a1f27-3cdb-61a4-cbdb-7bffd1032c8e@tu-dortmund.de>
2016-07-01 16:15 ` Alexander Lochmann
2016-07-01 16:56 ` David Smith
2016-07-01 17:47 ` Josh Stone
2016-07-06 12:29 ` Alexander Lochmann
2016-07-06 16:42 ` Frank Ch. Eigler
2016-07-06 20:05 ` Alexander Lochmann
2016-07-06 20:15 ` Frank Ch. Eigler
2016-07-06 20:27 ` Alexander Lochmann [this message]
2016-07-07 16:00 ` David Smith
2016-07-07 16:06 ` David Smith
2016-07-07 16:23 ` Alexander Lochmann
2016-07-07 17:39 ` David Smith
2016-07-07 20:51 ` Alexander Lochmann
2016-07-07 21:14 ` David Smith
2016-07-08 5:38 ` Alexander Lochmann
2016-07-08 15:31 ` David Smith
2016-07-07 18:47 ` David Smith
2016-07-07 19:01 ` Alexander Lochmann
2016-07-07 19:24 ` David Smith
2016-07-07 19:32 ` Alexander Lochmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=577D6996.40304@tu-dortmund.de \
--to=alexander.lochmann@tu-dortmund.de \
--cc=fche@redhat.com \
--cc=jistone@redhat.com \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).