From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75137 invoked by alias); 7 Jul 2016 16:23:09 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 75126 invoked by uid 89); 7 Jul 2016 16:23:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Including, galaxy, Galaxy, Nexus X-HELO: unimail.uni-dortmund.de Received: from mx1.HRZ.tu-dortmund.de (HELO unimail.uni-dortmund.de) (129.217.128.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 07 Jul 2016 16:22:58 +0000 Received: from [192.168.178.104] (x5d83ed5d.dyn.telefonica.de [93.131.237.93]) (authenticated bits=0) by unimail.uni-dortmund.de (8.16.0.16/8.16.0.16) with ESMTPSA id u67GMpfB018230 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Thu, 7 Jul 2016 18:22:51 +0200 (CEST) Subject: Re: SystemTap for Android - patchset To: David Smith , Josh Stone , systemtap@sourceware.org References: <56e0c7f4-d317-f76b-5156-3569a6097b62@tu-dortmund.de> <577CF9A2.7050008@tu-dortmund.de> <41638913-446d-4b2e-7fab-cfdeeca6170a@redhat.com> From: Alexander Lochmann Message-ID: <577E81DA.2@tu-dortmund.de> Date: Thu, 07 Jul 2016 16:23:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <41638913-446d-4b2e-7fab-cfdeeca6170a@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="n1CRr177LdfcDns4afUsXlXU5Huo8RbMh" X-IsSubscribed: yes X-SW-Source: 2016-q3/txt/msg00019.txt.bz2 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --n1CRr177LdfcDns4afUsXlXU5Huo8RbMh Content-Type: multipart/mixed; boundary="SqnGHaSfIaR1q0OFf23jJWG3HcfsTIsuS" From: Alexander Lochmann To: David Smith , Josh Stone , systemtap@sourceware.org Message-ID: <577E81DA.2@tu-dortmund.de> Subject: Re: SystemTap for Android - patchset References: <56e0c7f4-d317-f76b-5156-3569a6097b62@tu-dortmund.de> <577CF9A2.7050008@tu-dortmund.de> <41638913-446d-4b2e-7fab-cfdeeca6170a@redhat.com> In-Reply-To: <41638913-446d-4b2e-7fab-cfdeeca6170a@redhat.com> --SqnGHaSfIaR1q0OFf23jJWG3HcfsTIsuS Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 1782 On 07.07.2016 18:06, David Smith wrote: > On 07/06/2016 07:29 AM, Alexander Lochmann wrote: >> So. Let me start. >> First of all, I extracted the patches properly, and attached the files. >> (Btw, I found a third bug. :) ) >> FYI, I just fixed the bugs for the kernel versions I'm dealing with, >> because I don't know which other versions are affected as well. >=20 > Looking at your 2nd patch, '[PATCH 2/3] The syscall defines were not > compatible with older kernels, namely 3.0.x', this bit doesn't seem > correct at all: >=20 > =3D=3D=3D=3D > diff --git a/runtime/linux/autoconf-asm-syscall.c > b/runtime/linux/autoconf-asm-syscall.c > index bf7a273..6bfcd55 100644 > --- a/runtime/linux/autoconf-asm-syscall.c > +++ b/runtime/linux/autoconf-asm-syscall.c > @@ -1,2 +1,8 @@ > +#include > +#if LINUX_VERSION_CODE <=3D KERNEL_VERSION(3,0,200) && LINUX_VERSION_CODE >> =3D KERNEL_VERSION(3,0,0) > +#include > +#include > +#include > +#else > #include > - > +#endif > =3D=3D=3D=3D >=20 > Including is highly suspicious. Did you try to > include and get errors? If so, we can work to fix those > errors. Not including your arch's real syscall.h file will cause errors > down the road. >=20 An arch-specific syscall.h does not exist for arm. :( The kernel tree for both the Galaxy Nexus (maguro) and the Nexus 4 do not have a syscall.h (path: arch/arm/include/asm/syscall.h does not exist). - Alex --=20 Technische Universit=C3=A4t Dortmund Alexander Lochmann PGP key: 0xBC3EF6FD Otto-Hahn-Str. 16 phone: +49.231.7556141 D-44227 Dortmund fax: +49.231.7556116 http://ess.cs.tu-dortmund.de/Staff/al --SqnGHaSfIaR1q0OFf23jJWG3HcfsTIsuS-- --n1CRr177LdfcDns4afUsXlXU5Huo8RbMh Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXfoHaAAoJEFk+7QW8Pvb9tTIP/3e2luGJ2Y2JXzUC5gJ/6Ir7 lOmE7lfKsqcWNJFK12K89cD3Rwln1QCTtc39sEn0NsJFWQnJ1SJsxJ16CfUbDQPa Zehpdt/p3krNCNi6OhcdAGgds8H5bK2sz92zGe4cKBv515iqppA8+unIE0fiu5bJ LPQ9rgWCM4QzLiGqn7I89M/5zk6rAWksC2bvcIITt8BRBRIxTjEGiUjM0AmXVbSM xP1B9dwtAgUBz11vZ/nKSE5ESKmUkzcb03SrH+lWfIdVM5ApMtNU//S99paOeiuN L9HIyyhByOJvCtXmobqmn89nGf8QkegRm4kBZAVfadaIl9a+vBqmYNoIyJVxuJdR 0D2w6XyICOnRk2r1EZ/2kKMHLxCb4GvtMW0d3WmA8SYLsEHuUZRO9Og1D4Dq/A9F TKj+yhzz8NqG/XVNdigc2I5FqclMGg9SK0OSuQyrVykj2KONNoRUGFWdzeGnh0z3 ajokCVnQGrlfFEaPaWzUzLXYyWnxSS2TKbV+pkB2a31TQr5Q13LnC6WELZDTEoJC SxVMBoTNYlvwBBawhsEPQ/DoMlY+6vMsxR2lG8FfxSH+5Ecl58ERvQFXR+Dz+mq9 T0GVoMxJ0S2IOlifWWJVy+TxSxowA8TWUC2DSn72PCKh0abnFVpoy3pktPMFi3+1 dw56L7jTFlme6PpSpKPd =hDdW -----END PGP SIGNATURE----- --n1CRr177LdfcDns4afUsXlXU5Huo8RbMh--