From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 129230 invoked by alias); 7 Jul 2016 19:32:35 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 129217 invoked by uid 89); 7 Jul 2016 19:32:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=H*MI:sk:ef09061, H*f:sk:ef09061, H*i:sk:ef09061, staff X-HELO: unimail.uni-dortmund.de Received: from mx1.HRZ.tu-dortmund.de (HELO unimail.uni-dortmund.de) (129.217.128.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Thu, 07 Jul 2016 19:32:25 +0000 Received: from [192.168.178.104] (x5d83ed5d.dyn.telefonica.de [93.131.237.93]) (authenticated bits=0) by unimail.uni-dortmund.de (8.16.0.16/8.16.0.16) with ESMTPSA id u67JWIEA020830 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Thu, 7 Jul 2016 21:32:18 +0200 (CEST) Subject: Re: SystemTap for Android - patchset To: David Smith , Josh Stone , systemtap@sourceware.org References: <56e0c7f4-d317-f76b-5156-3569a6097b62@tu-dortmund.de> <577CF9A2.7050008@tu-dortmund.de> <822425cc-666c-c5dc-04bf-51898919a3b9@redhat.com> <577EA70B.9080806@tu-dortmund.de> From: Alexander Lochmann Message-ID: <577EAE41.1010503@tu-dortmund.de> Date: Thu, 07 Jul 2016 19:32:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="e5TFO0KXE0NWNJOLOWcp3PxxR5e6cQiE6" X-IsSubscribed: yes X-SW-Source: 2016-q3/txt/msg00026.txt.bz2 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --e5TFO0KXE0NWNJOLOWcp3PxxR5e6cQiE6 Content-Type: multipart/mixed; boundary="oh9Qc3p6R1MAnWlGmP78xnVvpWk5d189l" From: Alexander Lochmann To: David Smith , Josh Stone , systemtap@sourceware.org Message-ID: <577EAE41.1010503@tu-dortmund.de> Subject: Re: SystemTap for Android - patchset References: <56e0c7f4-d317-f76b-5156-3569a6097b62@tu-dortmund.de> <577CF9A2.7050008@tu-dortmund.de> <822425cc-666c-c5dc-04bf-51898919a3b9@redhat.com> <577EA70B.9080806@tu-dortmund.de> In-Reply-To: --oh9Qc3p6R1MAnWlGmP78xnVvpWk5d189l Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 2396 On 07.07.2016 21:24, David Smith wrote: > On 07/07/2016 02:01 PM, Alexander Lochmann wrote: >> On 07.07.2016 20:47, David Smith wrote: >>> On 07/06/2016 07:29 AM, Alexander Lochmann wrote: >>>> So. Let me start. >>>> First of all, I extracted the patches properly, and attached the files. >>>> (Btw, I found a third bug. :) ) >>>> FYI, I just fixed the bugs for the kernel versions I'm dealing with, >>>> because I don't know which other versions are affected as well. >>> >>> The problem you are trying to fix in your patch "[PATCH 1/3] Definition >>> of cputime_to_usecs in Linux kernel 3.0 is broken" is interesting. I >>> don't think you've got quite the right solution. Testing for a kernel >>> version here works for you, but really isn't a general solution - >>> depending on arch there could be a kernel in that range with a >>> reasonable cputime_to_usecs(). >> I see. :-/ Lesson learned. >>> >>> =3D=3D=3D=3D >>> diff --git a/tapset/linux/task_time.stp b/tapset/linux/task_time.stp >>> index f86f984..f3c276c 100644 >>> --- a/tapset/linux/task_time.stp >>> +++ b/tapset/linux/task_time.stp >>> @@ -27,8 +27,12 @@ >>> * Yet note some kernels (RHEL6) may already have both... */ >>> #if defined(cputime_to_usecs) >>> #if !defined(cputime_to_msecs) >>> +#if LINUX_VERSION_CODE <=3D KERNEL_VERSION(3,0,200) && LINUX_VERSION_C= ODE >>>> =3D KERNEL_VERSION(3,0,0) >>> +#define cputime_to_msecs(__ct) _stp_div64(NULL, >>> ({cputime_to_usecs(__ct)}), 1000ULL) >>> +#else >>> #define cputime_to_msecs(__ct) _stp_div64(NULL, >>> cputime_to_usecs(__ct), 1000ULL) >>> #endif >>> +#endif >>> >>> /* Kernels before 2.6.37 have cputime_to_msecs, but not usecs. */ >>> #elif defined(cputime_to_msecs) >>> =3D=3D=3D=3D >>> >>> I've got a couple of thoughts here: >>> >>> - I wonder if we just couldn't always use your workaround (along with a >>> comment about why we're doing that). >> Why not? :) Since the kernel and every module of course is compiled with >> -O3 (or -O2?), it shouldn't make any difference in the resulting >> assembler code. >=20 > Right. So, I checked in your fix as commit 2cc20af. >=20 Thanks. :) > Thanks. >=20 --=20 Technische Universit=C3=A4t Dortmund Alexander Lochmann PGP key: 0xBC3EF6FD Otto-Hahn-Str. 16 phone: +49.231.7556141 D-44227 Dortmund fax: +49.231.7556116 http://ess.cs.tu-dortmund.de/Staff/al --oh9Qc3p6R1MAnWlGmP78xnVvpWk5d189l-- --e5TFO0KXE0NWNJOLOWcp3PxxR5e6cQiE6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXfq5BAAoJEFk+7QW8Pvb93cUQAIcaHK6FbkkNYEvy95Q0Xtyv tQjiNs8UDniXyMTwZF6Zc3Sc0SY5kCh7okn4/iAkbeiAyd21TkU/CEQJJhE6UHu6 mdZccPuEd/xlIJK9T+n0JpCmkKBOuDMckWFPbvjyMcVTO87Z6LOKEH9QFif8TtqP dPec+V1hqVKuVS2MeKz0yhUqLi8haSYTJfp1GF4yD2GLso9MjplPT5DaJmDHC3We nUVMEvQX7gLkBk8XH0REmwe3Eh7yq591OYj0Cux2ClmFeP3Ff35K7zC+4K58vC2o fL7RYPWImSit5ZP4HdwYz/PZJ8mqqbPSM2sCGRpkffRdKAZC4Sfxq3fPefBM182Y GZfGgTmLX9buy297RPTc/ZEpGwGhsaK0I16wCGobGbaKLzJq83rRmOhEiIo0hUnX v0s2aMcAvf+r3THli3MX9kLDvwIu4lHPl5sVN0yVRAPpndOSO3sZncjnjwJykB43 6/H4ZVzo2gUVEHnKiFNLs1g0jhatSf4W7IZCUC+f/cMtfEmG5fLF4lyTe4MQZrZM C8zmrGtIR0o6MhaSKkd9Wx0L1ws2LAu0dFrobZaIYlOzX/rTahfGySk810LsALZE wPsCdjZ+F/V+H2iSo7o03q87VtbjPXnhJ+qLyBMS8lSySuIavZbmmWiN7dfoS0QQ Nk301CFYM9MZmswpD2lF =9Pqa -----END PGP SIGNATURE----- --e5TFO0KXE0NWNJOLOWcp3PxxR5e6cQiE6--