From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 51540 invoked by alias); 8 Jul 2016 05:38:50 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 51524 invoked by uid 89); 8 Jul 2016 05:38:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Hx-languages-length:2290, H*f:sk:27ef4d7, H*MI:sk:27ef4d7, H*i:sk:27ef4d7 X-HELO: unimail.uni-dortmund.de Received: from mx1.HRZ.tu-dortmund.de (HELO unimail.uni-dortmund.de) (129.217.128.51) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 08 Jul 2016 05:38:38 +0000 Received: from [192.168.178.104] (xd9bb8c85.dyn.telefonica.de [217.187.140.133]) (authenticated bits=0) by unimail.uni-dortmund.de (8.16.0.16/8.16.0.16) with ESMTPSA id u685cU3W015759 (version=TLSv1.2 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT); Fri, 8 Jul 2016 07:38:31 +0200 (CEST) Subject: Re: SystemTap for Android - patchset To: David Smith , Josh Stone , systemtap@sourceware.org References: <56e0c7f4-d317-f76b-5156-3569a6097b62@tu-dortmund.de> <577CF9A2.7050008@tu-dortmund.de> <41638913-446d-4b2e-7fab-cfdeeca6170a@redhat.com> <577E81DA.2@tu-dortmund.de> <3b77fcde-cf56-6c70-0c38-b1dbe7d5f37f@redhat.com> <914fe7f8-f8aa-63a1-7ff3-bea62a6a7301@tu-dortmund.de> <27ef4d79-281d-f7cc-2e98-433edc2256d8@redhat.com> From: Alexander Lochmann Message-ID: <577F3C55.6050508@tu-dortmund.de> Date: Fri, 08 Jul 2016 05:38:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.8.0 MIME-Version: 1.0 In-Reply-To: <27ef4d79-281d-f7cc-2e98-433edc2256d8@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sGn9gFQTTrCSdajxH14wkakOqrOpK7tlV" X-IsSubscribed: yes X-SW-Source: 2016-q3/txt/msg00030.txt.bz2 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --sGn9gFQTTrCSdajxH14wkakOqrOpK7tlV Content-Type: multipart/mixed; boundary="6B3DOpe5Ms4bmj69583UiF6QJGlOFiiCo" From: Alexander Lochmann To: David Smith , Josh Stone , systemtap@sourceware.org Message-ID: <577F3C55.6050508@tu-dortmund.de> Subject: Re: SystemTap for Android - patchset References: <56e0c7f4-d317-f76b-5156-3569a6097b62@tu-dortmund.de> <577CF9A2.7050008@tu-dortmund.de> <41638913-446d-4b2e-7fab-cfdeeca6170a@redhat.com> <577E81DA.2@tu-dortmund.de> <3b77fcde-cf56-6c70-0c38-b1dbe7d5f37f@redhat.com> <914fe7f8-f8aa-63a1-7ff3-bea62a6a7301@tu-dortmund.de> <27ef4d79-281d-f7cc-2e98-433edc2256d8@redhat.com> In-Reply-To: <27ef4d79-281d-f7cc-2e98-433edc2256d8@redhat.com> --6B3DOpe5Ms4bmj69583UiF6QJGlOFiiCo Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-length: 2354 On 07.07.2016 23:14, David Smith wrote: > On 07/07/2016 03:52 PM, Alexander Lochmann wrote: >> On 07.07.2016 19:39, David Smith wrote: >>> OK, I'll believe you. However, your fix above still isn't correct. The >>> whole point of autoconf-asm-syscall.c is to test if asm/syscall.h exists >>> and is usable. If so, STAPCONF_ASM_SYSCALL_H will get defined. If >>> autoconf-asm-syscall.c doesn't compile correctly, then >>> STAPCONF_ASM_SYSCALL_H won't be defined. >>> >>> What needs to happen next here is for you to back out this change, >>> recompile systemtap, then try to compile a few systemtap scripts. We'll >>> need to see the errors to know what to fix. I'd guess we'll need to test >>> STAPCONF_ASM_SYSCALL_H in some more places. >> Ok. Here is the error message I get: >> /tmp/stapE7HrAi/alexv9_src.c: In function >> 'function___global__stp_syscall_nr__overload_0': >> /tmp/stapE7HrAi/alexv9_src.c:7975:2: error: implicit declaration of >> function '_stp_syscall_get_nr' >> >> I tested three scripts so far. All of them do not compile due to the >> above error. >> Do you need one of the scripts? >=20 > Nope. >=20 > One of the reasons we include is to get the kernel's > syscall_get_nr() macros. If the kernel doesn't have a , > we define our own versions of syscall_get_nr() in runtime/syscall.h. The > arm platform already has our custom version of that macro in > runtime/syscall.h. >=20 > I'd guess we aren't including systemtap's runtime/syscall.h in the > proper place. Here's a patch that might work: >=20 > =3D=3D=3D=3D > diff --git a/tapset/linux/aux_syscalls.stp b/tapset/linux/aux_syscalls.stp > index 110e6e9..2cc3cea 100644 > --- a/tapset/linux/aux_syscalls.stp > +++ b/tapset/linux/aux_syscalls.stp > @@ -43,6 +43,8 @@ > // Get _stp_val_array and _stp_lookup_* definitions. > #include "linux/syscalls-common.h" >=20 > +#include "syscall.h" > + > static void > _stp_lookup_str2(const _stp_val_array * const array, long val, char *ptr, > int len, int base) > =3D=3D=3D=3D >=20 Yes. Works. :) At least for the four scripts I tested. - Alex --=20 Technische Universit=C3=A4t Dortmund Alexander Lochmann PGP key: 0xBC3EF6FD Otto-Hahn-Str. 16 phone: +49.231.7556141 D-44227 Dortmund fax: +49.231.7556116 http://ess.cs.tu-dortmund.de/Staff/al --6B3DOpe5Ms4bmj69583UiF6QJGlOFiiCo-- --sGn9gFQTTrCSdajxH14wkakOqrOpK7tlV Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" Content-length: 819 -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJXfzxWAAoJEFk+7QW8Pvb95+EQAMWt/l0rFvUuSjlcq0s16Bhl 1jPHuxmjqvqghcY5n92eF32RYPYcCNGAy+UCXZqawQataH5XWhTFoBO9s0iwed2u /q5ugk+lbhP60dtuLmjqhmMl0RY9hmraseHMHMRjblZjo9DG7lEHndxuX9Ce+/uT T9WGnwgUpqyKirIV7uR1VRZ1QASP7iali4dWf6EmXxFR7LFRpXl70umFDbhvrnTI 72zEAxP0m2uFmpiBC2QncpTjZz4nEq6l30BqyRi1glKihPNJDQm9eC5gGFkd8f9C XB5OYKNpm562kD2OHmWi1AyB0IMT1XHjjm98KpVDFB8+C2HAikZU7zMh49mX04XR dMGAOfNcrgZa1WMguH8sFtJy41Yj+GFde/wcOofpkCc+iTseXtWr65GM9MUye1bW TdC49JADTdOC1pKde5D/q/Yw56MGKdqFq/CUZJWgQ357NQDEMVIW2WgIUvmi06OL SF1BluCd8xpfC7X6PFbSeplt6fgd4w/ceVddghp3m2kZsgLa8sGU4X6JrHoSIRje NJrRDEga59zeCzu/fEhnxlxxj8oi8/ThtI7mn7HHoVXFdr6VRQW9DDl5G07Qjjuj yuYfeOlYKu1HPrOOI0/mx02EaclgkOj/OI0Hu9XIL2AAYaty4eTbcTwNxHvPpWye SE/UH0/NT3Amf6hkyQdb =IYdP -----END PGP SIGNATURE----- --sGn9gFQTTrCSdajxH14wkakOqrOpK7tlV--