From: "Zhang, Yanmin" <yanmin.zhang@intel.com>
To: "Andi Kleen" <ak@suse.de>, <prasanna@in.ibm.com>
Cc: <linux-kernel@vger.kernel.org>, <discuss@x86-64.org>,
<systemtap@sources.redhat.com>,
"Keshavamurthy, Anil S" <anil.s.keshavamurthy@intel.com>
Subject: RE: [discuss] [PATCH] utilization of kprobe_mutex is incorrect on x86_64
Date: Fri, 30 Sep 2005 06:34:00 -0000 [thread overview]
Message-ID: <8126E4F969BA254AB43EA03C59F44E84037191F2@pdsmsx404> (raw)
>>-----Original Message-----
>>From: Andi Kleen [mailto:ak@suse.de]
>>Sent: 2005年9月29日 22:31
>>To: prasanna@in.ibm.com
>>Cc: Zhang, Yanmin; linux-kernel@vger.kernel.org; discuss@x86-64.org;
>>systemtap@sources.redhat.com; Keshavamurthy, Anil S
>>Subject: Re: [discuss] [PATCH] utilization of kprobe_mutex is incorrect on
>>x86_64
>>
>>On Thursday 29 September 2005 16:13, Prasanna S Panchamukhi wrote:
>>> >On Thu, Sep 29, 2005 at 08:43:44AM +0800, Zhang, Yanmin wrote:
>>> >> <<kprobe_incorrect_kprobe_mutex_2.6.14-rc2_x86_64.patch>> I found it
>>> >> when reading the source codes. Basically, the bug could break
>>> >> kprobe_insn_pages under multi-thread environment. PPC arch also has the
>>> >> problem.
>>> >
>>> >Can you describe what the problem actually is?
>>>
>>> Andi,
>>>
>>> The up()/down() orders are incorrect in arch/x86_64/kprobes.c file while
>>> trying to get/remove a kprobes instruction slot in arch_prepare_kprobe()
>>> and arch_remove_kprobe() routines. Zhang's patch corrects this.
>>
>>What I meant is that someone should describe why they are incorrect.
>>I could probably figure it out from the code, but in general the standards
>>for changelogs are higher than just "bla is wrong". It should be more like
>>"bla doesn't do X, so bad thing Y happens, which causes crash Z". Please
>>follow this in future patches.
Andy,
Sorry for lack of detailed explanation. What Prasanna said is correct.
The up()/down() orders are incorrect in arch/x86_64/kprobes.c file. kprobe_mutext is used to protect the free kprobe instruction slot list. arch_prepare_kprobe applies for a slot from the free list, and arch_remove_kprobe returns a slot to the free list. The incorrect up()/down() orders to operate on kprobe_mutex fail to protect the free list. If 2 threads try to get/return kprobe instruction slot at the same time, the free slot list might be broken, or a free slot might be applied by 2 threads. My patch fixes it.
next reply other threads:[~2005-09-30 6:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-30 6:34 Zhang, Yanmin [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-09-29 14:14 Prasanna S Panchamukhi
2005-09-29 14:31 ` Andi Kleen
2005-09-29 0:45 Zhang, Yanmin
2005-09-29 13:15 ` [discuss] " Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8126E4F969BA254AB43EA03C59F44E84037191F2@pdsmsx404 \
--to=yanmin.zhang@intel.com \
--cc=ak@suse.de \
--cc=anil.s.keshavamurthy@intel.com \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=prasanna@in.ibm.com \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).