From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18077 invoked by alias); 9 Jan 2006 01:48:31 -0000 Received: (qmail 17872 invoked by uid 22791); 9 Jan 2006 01:48:30 -0000 X-Spam-Status: No, hits=0.6 required=5.0 tests=AWL,BAYES_40,DNS_FROM_RFC_POST X-Spam-Check-By: sourceware.org Received: from fmr19.intel.com (HELO orsfmr004.jf.intel.com) (134.134.136.18) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 09 Jan 2006 01:48:29 +0000 Received: from orsfmr101.jf.intel.com (orsfmr101.jf.intel.com [10.7.209.17]) by orsfmr004.jf.intel.com (8.12.10/8.12.10/d: major-outer.mc,v 1.1 2004/09/17 17:50:56 root Exp $) with ESMTP id k091mPJt031561; Mon, 9 Jan 2006 01:48:25 GMT Received: from pdsmsxvs01.pd.intel.com (pdsmsxvs01.pd.intel.com [172.16.12.122]) by orsfmr101.jf.intel.com (8.12.10/8.12.10/d: major-inner.mc,v 1.2 2004/09/17 18:05:01 root Exp $) with SMTP id k091mGmC028785; Mon, 9 Jan 2006 01:48:24 GMT Received: from pdsmsx331.ccr.corp.intel.com ([172.16.12.58]) by pdsmsxvs01.pd.intel.com (SAVSMTP 3.1.7.47) with SMTP id M2006010909482305883 ; Mon, 09 Jan 2006 09:48:23 +0800 Received: from pdsmsx404.ccr.corp.intel.com ([172.16.12.64]) by pdsmsx331.ccr.corp.intel.com with Microsoft SMTPSVC(6.0.3790.211); Mon, 9 Jan 2006 09:48:23 +0800 X-MimeOLE: Produced By Microsoft Exchange V6.5.7226.0 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="GB2312" Content-Transfer-Encoding: quoted-printable Subject: RE: Review patches of user space kprobe Date: Mon, 09 Jan 2006 01:48:00 -0000 Message-ID: <8126E4F969BA254AB43EA03C59F44E8404692D70@pdsmsx404> X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: Review patches of user space kprobe Thread-Index: AcYSo8i+B1oSELquQGWRF0giTjhfPwCGqOag From: "Zhang, Yanmin" To: Cc: , "Keshavamurthy, Anil S" , "Mao, Bibo" X-OriginalArrivalTime: 09 Jan 2006 01:48:23.0754 (UTC) FILETIME=[C6C15AA0:01C614BE] X-Scanned-By: MIMEDefang 2.52 on 10.7.209.17 X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2006-q1/txt/msg00064.txt.bz2 >>-----Original Message----- >>From: systemtap-owner@sourceware.org [mailto:systemtap-owner@sourceware.o= rg] On Behalf Of Prasanna S Panchamukhi >>Sent: 2006=C4=EA1=D4=C26=C8=D5 17:32 >>To: Zhang, Yanmin >>Cc: systemtap@sources.redhat.com; Keshavamurthy, Anil S; Mao, Bibo >>Subject: Re: Review patches of user space kprobe >> >>> >>> are only executed after the loop of hlist_for_each_entry. Is it cor= rect? >>> >>> >>> >> >>> >>that's correct. The page is mapped only once for the first match in t= he loop, >>> >>then all the probes are inserted into that page in the hlist_for_each= loop and >>> >>then the page is unmapped only once after the end of the loop. >>> So call lock_page for many times, and call unlock_page for one time? >>> >>no, lock_page and unlock_page is called only once, there is a small corre= ction, >>insert_probe_page() should be moved out of if condition so that all probes >>are inserted on that page. I'm still confused. Anyway, I will wait for your new codes. In addition, I = still think the second parameter of map_uprobe_page is not good and could b= e deleted. The logic related to the second parameter is very simple and cou= ld be moved to the caller of map_uprobe_page.=20