From: Timo Juhani Lindfors <timo.lindfors@iki.fi>
To: Mark Wielaard <mjw@redhat.com>
Cc: systemtap@sourceware.org
Subject: Re: RFC: improve build-id mismatch error reporting
Date: Tue, 20 Sep 2011 11:30:00 -0000 [thread overview]
Message-ID: <84iponih99.fsf@sauna.l.org> (raw)
In-Reply-To: <1315903072.3691.3.camel@springer.wildebeest.org> (Mark Wielaard's message of "Tue, 13 Sep 2011 10:37:52 +0200")
Mark Wielaard <mjw@redhat.com> writes:
> We should also include release/UTS_RELEASE in the output, it isn't the
> package version, but at least gives a hint of the kernel version
> involved.
The code compares UTS_RELEASE first and only then looks at
UTS_VERSION. Do you still think it makes sense to print UTS_RELEASE in
the UTS_VERSION mismatch case? (as in that case UTS_RELEASE matched
correctly).
> Only issue is that as the patch already implies, in the past this header
> was under include/linux/compile.h instead of
> include/generated/compile.h. We might need a runtime/autoconf check for
> that.
Autoconf test won't work since kernel versions can change after
systemtap has been built?
I looked around a bit but I'm not quite sure how to test this runtime.
next prev parent reply other threads:[~2011-09-20 11:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-13 7:54 Timo Juhani Lindfors
2011-09-13 8:38 ` Mark Wielaard
2011-09-20 11:30 ` Timo Juhani Lindfors [this message]
2011-09-20 12:52 ` Frank Ch. Eigler
2011-09-21 9:17 ` Timo Juhani Lindfors
2011-09-21 9:19 ` [PATCH] Tell the user if UTS_VERSION does not match running kernel Timo Juhani Lindfors
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=84iponih99.fsf@sauna.l.org \
--to=timo.lindfors@iki.fi \
--cc=mjw@redhat.com \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).