From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27279 invoked by alias); 18 Jan 2007 15:43:20 -0000 Received: (qmail 27272 invoked by uid 22791); 18 Jan 2007 15:43:20 -0000 X-Spam-Status: No, hits=-1.9 required=5.0 tests=BAYES_00,DK_SIGNED,SARE_MSGID_LONG40,SPF_PASS,TW_BX X-Spam-Check-By: sourceware.org Received: from an-out-0708.google.com (HELO an-out-0708.google.com) (209.85.132.242) by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 18 Jan 2007 15:43:14 +0000 Received: by an-out-0708.google.com with SMTP id b20so89189ana for ; Thu, 18 Jan 2007 07:43:12 -0800 (PST) DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=V4FTGVi0JFwB8iVu41vOZ8AvmnRjnM160etJ7MyFLG/5MGb/HKFQEJnCHuWcEvkDoIpwac2mYDH7rlDeRdmqsJYidbj3z+0BQ5CiUOKU65hdfclKN3DUIzPH4RaitWuk4xaZG+kBhA9jsZlGTJEdXo0/2TXYp5Ho8gZKlrANZDw= Received: by 10.100.127.1 with SMTP id z1mr223748anc.1169134992325; Thu, 18 Jan 2007 07:43:12 -0800 (PST) Received: by 10.70.35.7 with HTTP; Thu, 18 Jan 2007 07:43:12 -0800 (PST) Message-ID: <863e9df20701180743o3b81acf1xf54b701abc2d8ac8@mail.gmail.com> Date: Thu, 18 Jan 2007 15:43:00 -0000 From: "Abhishek Sagar" To: "rsmadhvesh@vsnl.net" Subject: Re: Kprobes Support for ARM arch Cc: systemtap@sources.redhat.com, madhvesh.s@ap.sony.com, satish.v@ap.sony.com In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070112053157.GA7437@in.ibm.com> X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2007-q1/txt/msg00139.txt.bz2 > > The attached patch addresses the branch instructions > > check for ARM kprobes last week release and avoids > > unexpected crash when probe is placed for branch > > type instructions. If any one finds issues, please let > > me know. > > > > Regards > > Madhvesh I would be a good defensive check to include bxj in the first switch case. The goto's can also be replaces with returns in case you only intend to do a 'return ret' in the 'kprobe_out' label. - Abhishek Sagar