From: fche@redhat.com (Frank Ch. Eigler)
To: Frank van der Linden <fllinden@amazon.com>
Cc: <systemtap@sourceware.org>
Subject: Re: [PATCH] arm64: use sregs for syscall probe registers
Date: Tue, 16 Apr 2019 15:33:00 -0000 [thread overview]
Message-ID: <87a7gqm0cf.fsf@redhat.com> (raw)
In-Reply-To: <5cb0cb1f.ROdjA4uUKaH5hT/r%fllinden@amazon.com> (Frank van der Linden's message of "Fri, 12 Apr 2019 17:30:07 +0000")
Frank van der Linden <fllinden@amazon.com> writes:
> Since syscall wrappers are now active on arm64 (4.19+), arguments need to
> be retrieved the right way, by checking if there is a saved set of system
> call registers, and using them if there are. [...]
This looks good to me.
> + if (STAP_ARG_argnum < 1 || STAP_ARG_argnum > 8) {
> + snprintf(CONTEXT->error_buffer, sizeof(CONTEXT->error_buffer),
> + "Cannot access arg(%lld)",
> + (long long)STAP_ARG_argnum);
> + CONTEXT->last_error = CONTEXT->error_buffer;
> + return;
> + }
By the way, as listed in [man stap], there are some helper macros to
make this a little more compact:
if (...) {
STAP_ERROR("foo bar %lld", (long long)foo);
}
- FChE
prev parent reply other threads:[~2019-04-16 15:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-12 17:30 Frank van der Linden
2019-04-15 21:32 ` William Cohen
2019-04-15 21:40 ` van der Linden, Frank
2019-04-16 15:33 ` Frank Ch. Eigler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7gqm0cf.fsf@redhat.com \
--to=fche@redhat.com \
--cc=fllinden@amazon.com \
--cc=systemtap@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).