public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: fche@redhat.com (Frank Ch. Eigler)
To: yaowenbin <yaowenbin1@huawei.com>
Cc: <systemtap@sourceware.org>,
	"hewenliang \(C\)" <hewenliang4@huawei.com>,
	linfeilong@huawei.com
Subject: Re: [PATCH] make 'local' only used in functions to avoid shellcheck error
Date: Fri, 19 Aug 2022 15:39:08 -0400	[thread overview]
Message-ID: <87lerkm3ab.fsf@redhat.com> (raw)
In-Reply-To: <94044055-5711-c12e-402e-08003322fa06@huawei.com> (yaowenbin via Systemtap's message of "Thu, 28 Jul 2022 17:16:57 +0800")


>  	if test -z "$val"; then
> -		local possibleval=$1
> +		possibleval=$1
>  		printf %s $1 "$possibleval" | grep ^- >/dev/null 2>&1

Can you please give an example of the error that this is fixing?

- FChE


  reply	other threads:[~2022-08-19 19:39 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-28  9:16 yaowenbin
2022-08-19 19:39 ` Frank Ch. Eigler [this message]
2023-04-26  7:50 langfei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lerkm3ab.fsf@redhat.com \
    --to=fche@redhat.com \
    --cc=hewenliang4@huawei.com \
    --cc=linfeilong@huawei.com \
    --cc=systemtap@sourceware.org \
    --cc=yaowenbin1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).