public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] make 'local' only used in functions to avoid shellcheck error
@ 2022-07-28  9:16 yaowenbin
  2022-08-19 19:39 ` Frank Ch. Eigler
  0 siblings, 1 reply; 2+ messages in thread
From: yaowenbin @ 2022-07-28  9:16 UTC (permalink / raw)
  To: systemtap; +Cc: hewenliang (C), linfeilong

Signed-off-by: yaowenbin <yaowenbin1@huawei.com>
---
 doc/Tapset_Reference_Guide/publicanize.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/doc/Tapset_Reference_Guide/publicanize.sh b/doc/Tapset_Reference_Guide/publicanize.sh
index 330409e..97254fe 100755
--- a/doc/Tapset_Reference_Guide/publicanize.sh
+++ b/doc/Tapset_Reference_Guide/publicanize.sh
@@ -22,7 +22,7 @@ do
 	val=`printf %s $1 | awk -F= '{print $2}'`
 	shift
 	if test -z "$val"; then
-		local possibleval=$1
+		possibleval=$1
 		printf %s $1 "$possibleval" | grep ^- >/dev/null 2>&1
 		if test "$?" != "0"; then
 			val=$possibleval
-- 
2.23.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] make 'local' only used in functions to avoid shellcheck error
  2022-07-28  9:16 [PATCH] make 'local' only used in functions to avoid shellcheck error yaowenbin
@ 2022-08-19 19:39 ` Frank Ch. Eigler
  0 siblings, 0 replies; 2+ messages in thread
From: Frank Ch. Eigler @ 2022-08-19 19:39 UTC (permalink / raw)
  To: yaowenbin; +Cc: systemtap, hewenliang (C), linfeilong


>  	if test -z "$val"; then
> -		local possibleval=$1
> +		possibleval=$1
>  		printf %s $1 "$possibleval" | grep ^- >/dev/null 2>&1

Can you please give an example of the error that this is fixing?

- FChE


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-08-19 19:39 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-28  9:16 [PATCH] make 'local' only used in functions to avoid shellcheck error yaowenbin
2022-08-19 19:39 ` Frank Ch. Eigler

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).