From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 8B1043858D28 for ; Fri, 19 Aug 2022 19:39:12 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 8B1043858D28 Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-653-zWn0wJQ1NzKGTkCKtKh-4Q-1; Fri, 19 Aug 2022 15:39:10 -0400 X-MC-Unique: zWn0wJQ1NzKGTkCKtKh-4Q-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 3EC46101A595; Fri, 19 Aug 2022 19:39:10 +0000 (UTC) Received: from redhat.com (unknown [10.2.17.198]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2FBAA2166B26; Fri, 19 Aug 2022 19:39:10 +0000 (UTC) Received: from [127.0.0.1] (helo=vm-rhel7) by redhat.com with esmtp (Exim 4.94.2) (envelope-from ) id 1oP7pk-0007fU-I5; Fri, 19 Aug 2022 15:39:09 -0400 From: fche@redhat.com (Frank Ch. Eigler) To: yaowenbin Cc: , "hewenliang \(C\)" , linfeilong@huawei.com Subject: Re: [PATCH] make 'local' only used in functions to avoid shellcheck error References: <94044055-5711-c12e-402e-08003322fa06@huawei.com> Date: Fri, 19 Aug 2022 15:39:08 -0400 In-Reply-To: <94044055-5711-c12e-402e-08003322fa06@huawei.com> (yaowenbin via Systemtap's message of "Thu, 28 Jul 2022 17:16:57 +0800") Message-ID: <87lerkm3ab.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-8.8 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: systemtap@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Systemtap mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Aug 2022 19:39:13 -0000 > if test -z "$val"; then > - local possibleval=$1 > + possibleval=$1 > printf %s $1 "$possibleval" | grep ^- >/dev/null 2>&1 Can you please give an example of the error that this is fixing? - FChE