From: fche@redhat.com (Frank Ch. Eigler)
To: yaowenbin <yaowenbin1@huawei.com>
Cc: <systemtap@sourceware.org>,
"hewenliang \(C\)" <hewenliang4@huawei.com>,
linfeilong@huawei.com
Subject: Re: fix network tcp test
Date: Fri, 19 Aug 2022 15:36:49 -0400 [thread overview]
Message-ID: <87r11cm3e6.fsf@redhat.com> (raw)
In-Reply-To: <b539fc10-11a3-fbb8-ab0d-31591a8fd86e@huawei.com> (yaowenbin via Systemtap's message of "Thu, 28 Jul 2022 17:13:51 +0800")
Hi -
(Thanks for the python patches; merged those at long last.)
> -probe ipmib.InUnknownProtos=kernel.function("icmp_send")
> +probe ipmib.InUnknownProtos=kernel.function("__icmp_send")
We can't fix things quite that way, because that would break on
older kernels.
probe ipmib.InUnknownProtos=kernel.function("icmp_send")! ,
kernel.function("__icmp_send")
would work on both old and new.
> probe _linuxmib.DelayedACKs.A = kernel.function("tcp_send_ack")
> {
> - sk=$sk
> + sk=pointer_arg(1)
Not quite ditto, but if the problem you're trying to solve is the
accessibility of $sk, a more systemtap-portable way of doing this
would be something like:
sk=@choose_defined($sk,pointer_arg(1))
- FChE
prev parent reply other threads:[~2022-08-19 19:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-28 9:13 yaowenbin
2022-08-19 19:36 ` Frank Ch. Eigler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r11cm3e6.fsf@redhat.com \
--to=fche@redhat.com \
--cc=hewenliang4@huawei.com \
--cc=linfeilong@huawei.com \
--cc=systemtap@sourceware.org \
--cc=yaowenbin1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).