From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 6E5373858D28 for ; Fri, 19 Aug 2022 19:36:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6E5373858D28 Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-270-tUyPizpLMoOCq-kAm0iyUw-1; Fri, 19 Aug 2022 15:36:50 -0400 X-MC-Unique: tUyPizpLMoOCq-kAm0iyUw-1 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.rdu2.redhat.com [10.11.54.1]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 924F529AA2E7; Fri, 19 Aug 2022 19:36:50 +0000 (UTC) Received: from redhat.com (unknown [10.2.17.198]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8312640CFD0A; Fri, 19 Aug 2022 19:36:50 +0000 (UTC) Received: from [127.0.0.1] (helo=vm-rhel7) by redhat.com with esmtp (Exim 4.94.2) (envelope-from ) id 1oP7nU-0007fH-Vk; Fri, 19 Aug 2022 15:36:49 -0400 From: fche@redhat.com (Frank Ch. Eigler) To: yaowenbin Cc: , "hewenliang \(C\)" , linfeilong@huawei.com Subject: Re: fix network tcp test References: Date: Fri, 19 Aug 2022 15:36:49 -0400 In-Reply-To: (yaowenbin via Systemtap's message of "Thu, 28 Jul 2022 17:13:51 +0800") Message-ID: <87r11cm3e6.fsf@redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.11.54.1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain X-Spam-Status: No, score=-9.0 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: systemtap@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Systemtap mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Aug 2022 19:36:53 -0000 Hi - (Thanks for the python patches; merged those at long last.) > -probe ipmib.InUnknownProtos=kernel.function("icmp_send") > +probe ipmib.InUnknownProtos=kernel.function("__icmp_send") We can't fix things quite that way, because that would break on older kernels. probe ipmib.InUnknownProtos=kernel.function("icmp_send")! , kernel.function("__icmp_send") would work on both old and new. > probe _linuxmib.DelayedACKs.A = kernel.function("tcp_send_ack") > { > - sk=$sk > + sk=pointer_arg(1) Not quite ditto, but if the problem you're trying to solve is the accessibility of $sk, a more systemtap-portable way of doing this would be something like: sk=@choose_defined($sk,pointer_arg(1)) - FChE