From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.20]) by sourceware.org (Postfix) with ESMTPS id F3B7D386F816 for ; Sun, 24 May 2020 16:29:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org F3B7D386F816 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gmx.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=Torsten.Polle@gmx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1590337763; bh=pbxrnlQJDfETXQMrmrXW6Ur9gCtpz/deD06HbuLir8w=; h=X-UI-Sender-Class:From:Subject:Date:To; b=Bhwq+fttZJR6W+FdoxyH5HjOf3b2RYcqPryWWquyXe8iPenV/zpmzGvVCmMCMmbnF 3SakIokQktuOZjDA+0tj/NRJqlu/ZOe6ilnJdO7xKyVwZI5q1lUFnsWm95iJNm1kTQ fiiVLFa/6F7nf5cleGV+MAj+1TtosApj/jBl/MxA= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from polle.fritz.box ([77.23.73.231]) by mail.gmx.com (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1N2V4J-1itQyq0Py3-013s8q for ; Sun, 24 May 2020 18:29:23 +0200 From: Torsten Polle Content-Type: multipart/mixed; boundary="Apple-Mail=_650FC3AB-6A7A-48A3-AF76-671177AA3ACA" Mime-Version: 1.0 (Mac OS X Mail 13.4 \(3608.80.23.2.2\)) Subject: Bug: MAXACTION errors + try/catch would lead to wrong src loc. Message-Id: <95C43BAB-F370-4B96-A660-724103DA3691@gmx.de> Date: Sun, 24 May 2020 18:29:22 +0200 To: systemtap@sourceware.org X-Mailer: Apple Mail (2.3608.80.23.2.2) X-Provags-ID: V03:K1:p4FkC4z1RWa+YYrTdAPE+bleGgX1qnNd5Lof670C6y73AdmzcTg GAZnByYBu1NoLidMK2esOHZSyqS8sKTUxq3CzMw37PhAf9tT/In0vckauyr62NRezcsLqUf B5QeNhKcDnIu/MfHPx6AJkTVmRWqzzC5eGOO0J+BbxAve1clEKLLDQxfFVTm4GUrfMNHL/h l6rZdU44ZVg+XGlZbkEyA== X-UI-Out-Filterresults: notjunk:1;V03:K0:Fb5OdT+AwM0=:ol4XWVpkme33gp5CldE8Kq CfLZ+yiM9uqP7LTd5RxjtJkftJDKEOq79JpwYoUxBPMlMMvF8kO89FxN8fXKMS+qM5Xv1NdYe yKdQYI7/SnL2dmEErybtzcDGgHHCFM0cDrARY8NggWIzMumP+mPqqjP+KgnIgdpFlXQirXjsO YUfs6g21nMxKFyA1qhPctQ/DD9z6ksEGfu2YEbfz9BRawy4j8MyWOHYvo3nxh8ZKchZuCsKnn CcC6H+wStOSqsfPFzaoBEwBMOFjd09FOIug8orZkr7yjEoVoRsXeqLrimx8cPlhV4KvcRO5h+ qyPAYT4mshlxFKijVpqyhUtqyPSg+QWLNwG9FratVuRMUykwfVit5Hzvo+u8ntAsmkAdJMYy/ yJjcN9PWhzy4DHgQ6p81xi9vj6j+QyZ+PPBa4YAR18KfhpALGT1ypbtFAg444iQAhVHsgWRfV 6JWQrxSX/cKK2E6fuFe6DEEFXZWvtPHsuEKo+qpuEbuvWU1h7DvCuPoEZp7Y+cjzbeLikutRg tJayHJdPLWXbmFfcsu0rm8XBxXINc6R1c8pSmAXCslc31W9i5T0sIZHx8RD6fgC2loU/mUpd8 KUoqs706YU15oLr0Y3IrzNSDJVjk89CulDXShr/2K1wuQ4n3skpuWMlXG1oOg2+h5AYhMtc79 Pq9mnFL5AgIfco3a54h6eETePWcmB8y4emkOiIhs6nvYIDF+kRglEsH+ZBBYLkq65K/5c6Q4H sbfi0WAs5T65gzDRj4RvLLqM3ZixTiFzIM97H01WABof7vDW/Ma0KTezbeBW2N0gVEIqrRyDo MjBGfJ4SUg+uqrwV1FNuhwUETQCL3lgweYixArWUuuu7JKTsynI4//OoCpX2f+9b5EFz/+/04 RLPrQ6aNCn+NfvPFXXLtHjfjeet5gIl0Ls7TCF2SYKqwcKnR2E6LNhEAVgTe3N7rbf5wk8NHN SFhZbor3VE/1AGUA1JrWYHd6gkks9pa4zF8G5sumffKzfrZzkpDOnEqVsD2YFqQvlxD4aD16x 4Auwzgxf8htEfM/ZQAHgjKed2nUtIz/4U+ghGMq1YSSyMFpUwTnIebykwZlYblvG6BESVhyu+ 1+gj8SuRqCBWS2/iQPZYveK0j/qpOz8iKldCozIUGu+Ul2j3YdCAQZulQ5P27bkw0Sdmsa3is o1blllTRTFb86PXxzLQGobU6n/aJQy+Pa1lVanKPfvtZK6XoozABVupf4NvZ+fLq9fi8tqFT6 m9tX0YJf4CsprhnIZ X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: systemtap@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Systemtap mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 24 May 2020 16:29:26 -0000 --Apple-Mail=_650FC3AB-6A7A-48A3-AF76-671177AA3ACA Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 Hi, When I pass the option --suppress-time-limits, I get a compile error. = This error has been introduced by the commit "Bug: MAXACTION errors + = try/catch would lead to wrong src loc." (91ffedd). There is one other place in the code, where the access to the field = =E2=80=9Aactionremaining=E2=80=98 of 'struct context' is guarded. I = added the guard that refers to the usage of the option = --suppress-time-limits also to the newly introduced access to the field. = But I=E2=80=99m not sure whether any of the other guards have to be = added as well. Kind Regards, Torsten --Apple-Mail=_650FC3AB-6A7A-48A3-AF76-671177AA3ACA Content-Disposition: attachment; filename=Fix-Bug-MAXACTION-errors-try-catch-would-lead-to-wro.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="Fix-Bug-MAXACTION-errors-try-catch-would-lead-to-wro.patch" Content-Transfer-Encoding: quoted-printable =46rom=208ce07d41df539b755f3a16f287537e474cfa9c86=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Torsten=20Polle=20=0A= Date:=20Sun,=2024=20May=202020=2013:27:31=20+0200=0ASubject:=20[PATCH]=20= Fix:=20Bug:=20MAXACTION=20errors=20+=20try/catch=20would=20lead=20to=20= wrong=0A=20src=20loc.=0A=0AThe=20structure=20context=20c=20does=20not=20= always=20contain=20the=20field=0Aactionremaining.=20If=20the=20argument=20= --suppress_time_limits=20is=20given,=20the=0Afield=20is=20not=20= declared.=0A---=0A=20translate.cxx=20|=2011=20+++++++----=0A=201=20file=20= changed,=207=20insertions(+),=204=20deletions(-)=0A=0Adiff=20--git=20= a/translate.cxx=20b/translate.cxx=0Aindex=20f142667..3fe284b=20100644=0A= ---=20a/translate.cxx=0A+++=20b/translate.cxx=0A@@=20-3771,10=20+3771,13=20= @@=20void=20c_unparser::visit_try_block=20(try_block=20*s)=0A=20=0A=20=20= =20o->newline()=20<<=20"if=20(likely(c->last_error=20=3D=3D=20NULL))=20= goto=20out;";=0A=20=0A-=20=20//=20NB:=20MAXACTION=20errors=20are=20not=20= catchable=20and=20we=20should=20never=20clear=20the=20error=0A-=20=20//=20= message=20below=20otherwise=20the=20source=20location=20in=20the=20= message=20would=0A-=20=20//=20become=20inaccurate=20(always=20being=20= the=20top-level=20try/catch=20statement's).=0A-=20=20o->newline()=20<<=20= "if=20(unlikely=20(c->actionremaining=20<=3D=200))=20goto=20out;";=0A+=20= =20if=20(!session->suppress_time_limits)=0A+=20=20=20=20{=0A+=20=20=20=20= =20=20//=20NB:=20MAXACTION=20errors=20are=20not=20catchable=20and=20we=20= should=20never=20clear=20the=20error=0A+=20=20=20=20=20=20//=20message=20= below=20otherwise=20the=20source=20location=20in=20the=20message=20would=0A= +=20=20=20=20=20=20//=20become=20inaccurate=20(always=20being=20the=20= top-level=20try/catch=20statement's).=0A+=20=20=20=20=20=20o->newline()=20= <<=20"if=20(unlikely=20(c->actionremaining=20<=3D=200))=20goto=20out;";=0A= +=20=20=20=20}=0A=20=0A=20=20=20if=20(s->catch_error_var)=0A=20=20=20=20=20= {=0A--=20=0A2.7.4=0A=0A= --Apple-Mail=_650FC3AB-6A7A-48A3-AF76-671177AA3ACA--