RE: Recent test results

["Mao, Bibo" <bibo.mao@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 1836 bytes --]

Yes, after add close and wait sentence in stap_run.exp. There will be no timeout information. But after "runtest" command, if we use lsmod command, there will be some module that is not uninstalled named stapxxx.

Maybe it is because of spawn process is closed before it unload stap module. We can print some information when rmmod in file librelay.c. And then expect this information in stap_run.exp script, and at last after unload module, we can close this process.

By the way stap_fun.exp function is only called by runtest script in systemtap.base directory, and in systemtap.samples directory it is not. Maybe we add wait sentence in each runtest exp script in systemtap.samples directory.

The attachment is patch for librelay.c and stap_run.exp.

>-----Original Message-----
>From: systemtap-owner@sourceware.org [mailto:systemtap-owner@sourceware.org]
>On Behalf Of Martin Hunt
>Sent: 2005年11月12日 4:53
>To: Keshavamurthy, Anil S
>Cc: William Cohen; systemtap@sources.redhat.com
>Subject: RE: Recent test results
>
>On Fri, 2005-11-11 at 12:49 -0800, Keshavamurthy, Anil S wrote:
>> Martin,
>> 	Can you mail your fix so I can verify the same on my Ia64 box.
>>
>> -thanks,
>> Anil
>
>Index: testsuite/lib/stap_run.exp
>===================================================================
>RCS file: /cvs/systemtap/tests/testsuite/lib/stap_run.exp,v
>retrieving revision 1.5
>retrieving revision 1.6
>diff -u -r1.5 -r1.6
>--- testsuite/lib/stap_run.exp  2 Sep 2005 22:34:12 -0000       1.5
>+++ testsuite/lib/stap_run.exp  11 Nov 2005 20:37:47 -0000      1.6
>@@ -51,6 +51,8 @@
>        timeout { fail "$test startup (timeout)" }
>        eof { fail "$test startup (eof)" }
>     }
>+  close
>+  wait
> }
>
> proc no_load {} {
>
>--------
>
>It's checked into CVS.
>
>Martin
>


[-- Attachment #2: patch_stap_run --]
[-- Type: application/octet-stream, Size: 706 bytes --]

--- orig/lib/stap_run.exp	2005-09-03 06:34:12.000000000 +0800
+++ runtest/lib/stap_run.exp	2005-11-14 03:21:55.000000000 +0800
@@ -42,6 +42,16 @@
 	    expect {
 		-re  $output {
 		    pass "$test shutdown and output"
+		
+		    set output "^systemtap unload module successfully\n$"
+		    expect {
+			-re $output{
+				pass "$test unload module"
+				close
+			}
+			timeout {fail "$test unload module (timeout)"}
+			eof { fail "$test unload module (eof)"}	
+		    }			
 		}
 		timeout { fail "$test shutdown (timeout)" }
 		eof { fail "$test shutdown (eof)" }
@@ -51,6 +61,7 @@
 	timeout { fail "$test startup (timeout)" }
 	eof { fail "$test startup (eof)" }
     }
+    wait
 }
 
 proc no_load {} {

[-- Attachment #3: patch_librelay --]
[-- Type: application/octet-stream, Size: 281 bytes --]

--- systemtap-20051112.orig/runtime/stpd/librelay.c	2005-10-20 03:35:35.000000000 +0800
+++ systemtap-20051112/runtime/stpd/librelay.c	2005-11-14 03:03:31.000000000 +0800
@@ -631,6 +631,7 @@
 			exit(1);
 		}
 	}
+	printf("systemtap unload module successfully\n");
 	exit(0);
 }