public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: "Serhei Makarov" <me@serhei.io>
To: "Daire Byrne" <daire@dneg.com>, systemtap <systemtap@sourceware.org>
Subject: Re: newer kernel+systemtap & nfs.fop.open
Date: Fri, 01 Apr 2022 16:13:15 -0400	[thread overview]
Message-ID: <9adcadfd-e6ba-4c0b-8e64-892ec7173bac@www.fastmail.com> (raw)
In-Reply-To: <6a4c5961-df38-40d6-9491-1f5a587a3dbf@www.fastmail.com>



On Fri, Apr 1, 2022, at 10:55 AM, Serhei Makarov wrote:
> In this case the last commit
> to tapsets/linux/dentry.stp was in 2020
> so it looks like we may have some catching up to the kernel
> to do. I'll investigate more (i.e. delve into kernel git history)
> and get back to you.
I'm got a 'read fault' running your example on Fedora 5.15.4-201.fc35.x86_64,
which indicates even further divergence later on.
Which kernel version were you running the example on?

Looks like "struct mount" no longer defines the "mnt_parent" member
used by task_dentry_path() tapset function in /usr/share/systemtap/tapset/linux/dentry.stp
which is strange as the upstream Linux kernel code still uses that member
in the equivalent fs/d_path.c __prepend_path code.

sutap -ve 'probe begin { if (@type_member_defined("mount", mnt_parent)) { print("foo") } else { print("bar") } exit() }'

Very strange, as even checking the debugsource doesn't show any downstream changes
as found by

$ debuginfod-find source /boot/vmlinuz-5.15.4-201.fc35.x86_64 /usr/src/debug/kernel-5.15.4/linux-5.15.4-201.fc35.x86_64/fs/d_path.c

I'm also confused and will continue investigating until I become unconfused.

  reply	other threads:[~2022-04-01 20:13 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-10 19:58 Daire Byrne
2022-04-01 12:26 ` Daire Byrne
2022-04-01 14:05   ` David Smith
2022-04-01 14:55   ` Serhei Makarov
2022-04-01 20:13     ` Serhei Makarov [this message]
2022-04-04 11:21       ` Daire Byrne
2022-04-04 12:28         ` Daire Byrne

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9adcadfd-e6ba-4c0b-8e64-892ec7173bac@www.fastmail.com \
    --to=me@serhei.io \
    --cc=daire@dneg.com \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).