From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30804 invoked by alias); 21 Apr 2011 20:17:37 -0000 Received: (qmail 30796 invoked by uid 22791); 21 Apr 2011 20:17:35 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST X-Spam-Check-By: sourceware.org Received: from mail-pw0-f41.google.com (HELO mail-pw0-f41.google.com) (209.85.160.41) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 21 Apr 2011 20:17:21 +0000 Received: by pwi10 with SMTP id 10so76601pwi.0 for ; Thu, 21 Apr 2011 13:17:19 -0700 (PDT) MIME-Version: 1.0 Received: by 10.68.22.195 with SMTP id g3mr506073pbf.174.1303417038901; Thu, 21 Apr 2011 13:17:18 -0700 (PDT) Received: by 10.68.44.67 with HTTP; Thu, 21 Apr 2011 13:17:18 -0700 (PDT) In-Reply-To: <4DAF3D59.7020609@redhat.com> References: <4DAF3D59.7020609@redhat.com> Date: Thu, 21 Apr 2011 20:17:00 -0000 Message-ID: Subject: Re: Linux VFS cache hit rate script From: Jake Maul To: William Cohen Cc: systemtap@sourceware.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2011-q2/txt/msg00144.txt.bz2 New version of the script uploaded to War Stories, incorporating your suggested changes. I have no problem with the GPLv2, so I took your wording exactly. :) http://sourceware.org/systemtap/wiki/WSCacheHitRate Of course there's still the concern about devname "N/A", but I clarified the comment so as to make it obvious where I got that assumption from. At least then if does turn out to be incorrect, it will be obvious that something other than just this one script needs to be fixed. Jake On Wed, Apr 20, 2011 at 1:08 PM, William Cohen wrote: > On 04/20/2011 03:04 PM, Jake Maul wrote: >> Greetings all, > > Hi Jake, > > Thanks for taking the time to submit the example. > >> >> I have recently put a script up on the War Stories page, and it was >> requested of me to also post it to the list, along with a .meta file. >> They're both attached. >> >> http://sourceware.org/systemtap/wiki/WSCacheHitRate > > Why the need for =A0-DMAXMAPENTRIES=3D100000 on the second example on the= wiki page? There doesn't seem to be any arrays in the script. > >> >> Let me know what you think! It's my first SystemTap script, so I'm >> sure there are improvements that could be made. I'm by no means a >> kernel hacker, or even a C dev... just a lowly sysadmin. :) > > Include a short header like the following at the beginning of the script: > > #!/usr/bin/env stap > # cache-hit.stp > # Copyright (C) 2011 xxx > # > # This program is free software; you can redistribute it and/or modify > # it under the terms of the GNU General Public License version 2 as > # published by the Free Software Foundation. > > > Should avoid long line lengths in the printf statements. Wrapped lines do= n't look good in manuals. > > > The following line sounds unsure, need to check that that is really the c= ase: > > =A0if (devname=3D=3D"N/A") { /* N/A means cache hit... right? */ > > It would be good to have a better explanation for the "N/A" check. > > -Will > >