From: "Stone, Joshua I" <joshua.i.stone@intel.com>
To: "Frank Ch. Eigler" <fche@redhat.com>, "Mike Mason" <mmlnx@us.ibm.com>
Cc: <systemtap@sources.redhat.com>
Subject: RE: Fwd: Any way to find the network usage by a process?
Date: Fri, 06 Oct 2006 01:08:00 -0000 [thread overview]
Message-ID: <C56DB814FAA30B418C75310AC4BB279DB975C3@scsmsx413.amr.corp.intel.com> (raw)
On Thursday, October 05, 2006 5:00 PM, Frank Ch. Eigler wrote:
> Hi -
>
> On Thu, Oct 05, 2006 at 04:28:10PM -0700, Mike Mason wrote:
>> [...]
>> ERROR: empty aggregate near identifier 'execname' at nettop.stp:35:4
>> WARNING: Number of errors: 1, skipped probes: 0
>> Apparently using @sum on empty aggregates isn't allowed. I expected
>> 0's to be returned.
>
> As a judgement call, to be consistent with other extractors like @avg,
> the @sum etc. of an empty set was deemed to be undefined.
FWIW, Python allows you to take the sum of an empty list, even though
other equivalent extractors fail:
>>> sum([])
0
>>> max([])
Traceback (most recent call last):
File "<stdin>", line 1, in ?
ValueError: min() or max() arg is an empty sequence
I'm just looking for precedence in other languages...
>> The only way to avoid the error is use @sum only if @count >
>> 0, which makes the printf too complex in my opinion.
>
> Maybe so. It's worth considering some syntactic sugar to express a
> undefined=>0 intent.
One possibility is an optional second parameter to the extractor that
gives a default value. We could require this to be a constant (usually
0), or maybe even allow a numeric expression.
a <<< 1; del a // prepare an empty aggregate
printf("%d\n", @sum(a)) // runtime error
printf("%d\n", @sum(a, 0)) // prints 0
printf("%d\n", @sum(a, x)) // prints value of x
This works for min, max, and avg as well.
Or, instead of a default, it might be less confusing to consider the
second parameter as an initializer -- so when 'a' isn't empty, @sum(a,x)
== x + @sum(a). Then min and max would effectively get an upper and
lower bound, respectively. I'm not sure if avg works well this way
though.
Josh
next reply other threads:[~2006-10-06 1:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-06 1:08 Stone, Joshua I [this message]
[not found] <3420082f0610030114o5b44b8ak7797483e02002614@mail.gmail.com>
[not found] ` <3420082f0610030114o4c6998en907bccce81d28c59@mail.gmail.com>
2006-10-03 15:49 ` Jose R. Santos
2006-10-04 20:54 ` Mike Mason
2006-10-05 21:22 ` Frank Ch. Eigler
2006-10-05 23:28 ` Mike Mason
2006-10-06 0:00 ` Frank Ch. Eigler
2006-10-06 1:10 ` Mike Mason
2006-10-06 15:30 ` Frank Ch. Eigler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=C56DB814FAA30B418C75310AC4BB279DB975C3@scsmsx413.amr.corp.intel.com \
--to=joshua.i.stone@intel.com \
--cc=fche@redhat.com \
--cc=mmlnx@us.ibm.com \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).