From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 32341 invoked by alias); 9 Oct 2006 19:39:29 -0000 Received: (qmail 32334 invoked by uid 22791); 9 Oct 2006 19:39:28 -0000 X-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from mga03.intel.com (HELO mga03.intel.com) (143.182.124.21) by sourceware.org (qpsmtpd/0.31) with ESMTP; Mon, 09 Oct 2006 19:39:26 +0000 Received: from azsmga001.ch.intel.com ([10.2.17.19]) by mga03.intel.com with ESMTP; 09 Oct 2006 12:39:23 -0700 Received: from scsmsx331.sc.intel.com (HELO scsmsx331.amr.corp.intel.com) ([10.3.90.4]) by azsmga001.ch.intel.com with ESMTP; 09 Oct 2006 12:39:22 -0700 X-ExtLoop1: 1 X-IronPort-AV: i="4.09,285,1157353200"; d="scan'208"; a="128831578:sNHT23023742" Received: from scsmsx413.amr.corp.intel.com ([10.3.90.32]) by scsmsx331.amr.corp.intel.com with Microsoft SMTPSVC(6.0.3790.211); Mon, 9 Oct 2006 12:39:22 -0700 X-MimeOLE: Produced By Microsoft Exchange V6.5 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Subject: RE: S390 _stp_gettimeofday_ns() change Date: Mon, 09 Oct 2006 19:39:00 -0000 Message-ID: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: S390 _stp_gettimeofday_ns() change Thread-Index: Acbr1J8M6eLQA31YRP2QT8wbSRIBswABbpeA From: "Stone, Joshua I" To: "David Wilder" Cc: X-OriginalArrivalTime: 09 Oct 2006 19:39:22.0076 (UTC) FILETIME=[9E78E9C0:01C6EBDA] X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2006-q4/txt/msg00051.txt.bz2 On Monday, October 09, 2006 12:33 PM, David Wilder wrote: > While investigating a possible compiler bug on the s390 affecting > __stp_estimate_cpufreq(), I came to the conclusion that this function > made little sense on the s390. Both get_cycles() and udelay() use the > TOD clock. On the s390 the TOD is always at a known frequency on all > models. The following patch to _stp_gettimeofday_ns() simply > converts get_cycles()'s return value into nanoseconds and it has the > side effect of avoiding the gcc bug :) >=20 > The per-cpu timer values are also not needed on the s390 as all cpus > use the same TOD clock. However, I did not remove this code for ease > of maintenance. Committed. I don't have an s390 to test, so I'll have to assume you know what you're talking about. ;) Josh