From: Sandeepa Prabhu <sandeepa.prabhu@linaro.org>
To: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Cc: William Cohen <wcohen@redhat.com>,
systemtap@sourceware.org, Deepak Saxena <dsaxena@linaro.org>,
Krishna Dani <krishna.mohan@linaro.org>,
Jakub Pavelek <jakub.pavelek@linaro.org>
Subject: Re: Re: Re: Regarding systemtap support for AArch64
Date: Thu, 24 Oct 2013 04:26:00 -0000 [thread overview]
Message-ID: <CA+b37P1Ep9vySUw7vozAgdgEwwq6mEnZEaf1kCKugdGbdOh7Vw@mail.gmail.com> (raw)
In-Reply-To: <525D0D39.10404@hitachi.com>
On 15 October 2013 15:09, Masami Hiramatsu
<masami.hiramatsu.pt@hitachi.com> wrote:
> (2013/10/07 20:12), Sandeepa Prabhu wrote:
>>>>>>>>> - Is it really need to use spinlock to protect break_hook?
>>>>>>>> Any cpu can remove breakpoint hooks right, and traversal happen in
>>>>>>>> debug exception context so mutex are not safe (can sleep/schedule out)
>>>>>>>> in debug exception.
>>>>>>>
>>>>>>> I don't think we need to remove the breakpoint hooks after starting
>>>>>>> up the kernel. If we use the spinlock there, we'll pay a big cost
>>>>>>> because of the lock contention.
>>>>>> Not in kprobes. But kgdb can remove breakpoint handler and use same
>>>>>> API. or atleast while providing an api we should not assume race
>>>>>> cannot happen right?
>>>>>
>>>>> In that case, we'd better add a wrapper handler for kgdb so that
>>>>> the list isn't updated even if the kgdb removes its handler.
>>>>>
>>>>>> And there wont be much lock contention, i'ts only if the debug
>>>>>> framework (like kgdb) is wrapping-up, not is normal use-case.
>>>>>
>>>>> Hmm, it seems that the spinlock is locked while handling a breakpoint.
>>>>> This will cause a bad performance issue when we put many kprobes
>>>>> on SMP system.
>>>> arm maintainers prefer a reader/writer spin-locks, so there wont be
>>>> lock contention in debug path, each instance of kprobe hook trap (on
>>>> any CPU) would be a reader, not blocking.
>>>
>>> OK for the first step, and it eventually should be fixed to lockless.
>>> (depends on the performance improvement)
>> Hmm, is there a performance requirement for systemtap or perf? -like
>> how much time each test suite should consume etc?
>
> Basically, for the enterprise use, we aims to get less than 5% loss
> of runtime performance. Of course it depends on the configuration.
> This requirement comes from the usage of tracing, it's usually used
> as a "flight-recorder" in such system. For analyzing the root cause
> of the trouble, some fundamental events are always recorded into a
> memory buffer. When encountering a trouble, the buffer will be dumped,
> and trouble shooting team analyzes it.
>
> Thus, I'd like to make the performance overhead of tracing as
> small as possible.
Hmm, my worry is whether we can really measure and improve performance
or not -running on foundation model, do not have real hardware access
right now :(
>
> However, for debugging use, the performance degradation is not
> so important.
>
>> Want to know the acceptance criteria for systemtap or perf to say
>> 'kprobes/uprobes on an architecture' is complaint and good enough for
>> tracing?
>
> I think there is no such criteria. The overhead problem depends on the
> use-cases as I said above. If it is functional, it's enough to use by
> perf/ftrace ;) Performance optimization can be done afterwords.
>
> Thank you,
>
> --
> Masami HIRAMATSU
> IT Management Research Dept. Linux Technology Center
> Hitachi, Ltd., Yokohama Research Laboratory
> E-mail: masami.hiramatsu.pt@hitachi.com
>
>
next prev parent reply other threads:[~2013-10-24 4:26 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-24 3:13 Sandeepa Prabhu
2013-09-24 8:43 ` Mark Wielaard
2013-09-24 9:36 ` Sandeepa Prabhu
2013-09-25 18:45 ` William Cohen
2013-09-26 3:13 ` Sandeepa Prabhu
2013-09-26 14:35 ` William Cohen
2013-09-26 14:57 ` Sandeepa Prabhu
2013-09-27 14:16 ` William Cohen
2013-09-30 2:36 ` Masami Hiramatsu
2013-09-30 2:57 ` Sandeepa Prabhu
2013-09-30 12:11 ` William Cohen
2013-10-02 4:17 ` Sandeepa Prabhu
2013-10-02 11:24 ` Masami Hiramatsu
2013-10-03 3:12 ` Sandeepa Prabhu
2013-10-03 13:01 ` Masami Hiramatsu
2013-10-04 3:24 ` Sandeepa Prabhu
2013-10-05 3:24 ` Masami Hiramatsu
2013-10-07 9:51 ` Sandeepa Prabhu
2013-10-07 10:11 ` Masami Hiramatsu
2013-10-07 11:12 ` Sandeepa Prabhu
2013-10-15 9:39 ` Masami Hiramatsu
2013-10-24 4:26 ` Sandeepa Prabhu [this message]
2013-10-24 5:08 ` Masami Hiramatsu
2013-10-04 15:57 ` William Cohen
2013-10-07 9:26 ` Sandeepa Prabhu
2013-10-08 4:28 ` Sandeepa Prabhu
2013-10-08 4:39 ` Sandeepa Prabhu
2013-10-14 16:38 ` William Cohen
2013-10-14 21:21 ` William Cohen
2013-10-15 2:29 ` Sandeepa Prabhu
2013-10-15 3:02 ` William Cohen
2013-10-16 2:33 ` William Cohen
2013-10-16 2:38 ` William Cohen
2013-10-24 1:50 ` William Cohen
2013-10-24 4:19 ` Sandeepa Prabhu
2013-10-24 13:49 ` William Cohen
2013-10-28 14:03 ` William Cohen
2013-11-01 21:06 ` William Cohen
2013-09-25 4:42 ` Masami Hiramatsu
2013-12-02 15:45 ` An attempt for systemtap "make installcheck" AArch64 William Cohen
2013-12-03 5:25 ` Sandeepa Prabhu
2013-12-03 15:21 ` William Cohen
2013-12-03 16:36 ` William Cohen
2013-12-09 20:35 ` William Cohen
2013-12-16 6:06 ` Sandeepa Prabhu
2013-12-16 12:41 ` William Cohen
2013-12-03 19:48 ` William Cohen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+b37P1Ep9vySUw7vozAgdgEwwq6mEnZEaf1kCKugdGbdOh7Vw@mail.gmail.com \
--to=sandeepa.prabhu@linaro.org \
--cc=dsaxena@linaro.org \
--cc=jakub.pavelek@linaro.org \
--cc=krishna.mohan@linaro.org \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=systemtap@sourceware.org \
--cc=wcohen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).