From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26079 invoked by alias); 21 Apr 2014 22:20:08 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 26070 invoked by uid 89); 21 Apr 2014 22:20:08 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=1.7 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 X-HELO: mail-qa0-f47.google.com Received: from mail-qa0-f47.google.com (HELO mail-qa0-f47.google.com) (209.85.216.47) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES128-SHA encrypted) ESMTPS; Mon, 21 Apr 2014 22:20:07 +0000 Received: by mail-qa0-f47.google.com with SMTP id m5so4244067qaj.6 for ; Mon, 21 Apr 2014 15:20:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=5YQcD0ftv9Vr/L6kZhr6IBgrNgFtlRgfFruIF4+Kojc=; b=FbaoPyMEgKESCR3otqxRShmyr+dpfLA0VnwEPI08aWDtiCmll5gw1QsKBqaUzXeX+5 zrw+hhOuYMbo1ACyO96WXMv60zRcKGFEcT14LfyBQg1wW3ZgDQDMJJ3vTfvy4nsRY504 5fATw9ZsxKjHa7iAPcmbFqzatIBBPqC918y0ieE8cIKMb6Hx+E//qEy6/qnvMdVeRYuE tBgp5cOrBHviOLeawkC7yKPmRwKf/mDrDCcePsIkujS7Bot6SrqV8VWula1Vkm6jXjt5 HFWluX83WSSP/BB9IzrwAfQtlL9i4P0TOr7pjBPo0eADlhQv9BlyDmTnlkxYfmZNZ/oM KUPQ== X-Gm-Message-State: ALoCoQkN2JYlf1KX4S9v54aYIaHzycf28bYruGauOf6blkSM+1EPviKYm9Lic0KF0/dGLuF0JEhQ MIME-Version: 1.0 X-Received: by 10.224.22.65 with SMTP id m1mr6392519qab.103.1398118805026; Mon, 21 Apr 2014 15:20:05 -0700 (PDT) Received: by 10.229.95.6 with HTTP; Mon, 21 Apr 2014 15:20:04 -0700 (PDT) In-Reply-To: <53557C5F.4040702@redhat.com> References: <53557C5F.4040702@redhat.com> Date: Mon, 21 Apr 2014 22:20:00 -0000 Message-ID: Subject: Re: systemtap test suite compilation failed: include/linux/sysfs.h:449:2: argument 2 of 'kernfs_find_and_get' differ in signedness From: Victor Kamensky To: William Cohen , Naresh Kamboju Cc: "Frank Ch. Eigler" , systemtap@sourceware.org, Fathi Boudra , Milosz Wasilewski Content-Type: text/plain; charset=UTF-8 X-IsSubscribed: yes X-SW-Source: 2014-q2/txt/msg00082.txt.bz2 On 21 April 2014 13:15, William Cohen wrote: > On 04/19/2014 02:53 PM, Naresh Kamboju wrote: >> Hi, >> >> The systemtap test suite compilation failed with below error. > > Hi, > > On an ARM chromebook I have a linux kernel built from the mainline git repository (2.15.0-rc2) and the current version of systemtap checked out from the git repo. I am not seeing the error messages below. William, Does your kernel config have CONFIG_CC_STACKPROTECTOR set? Also what is your compiler version? On my arndale board everything works OK with CONFIG_CC_STACKPROTECTOR=y and Linaro OE based rootfs with gcc Linaro GCC 4.8-2014.02: Here are my settings: root@genericarmv7a:~# zcat /proc/config.gz | grep STACKPROTECTOR CONFIG_HAVE_CC_STACKPROTECTOR=y CONFIG_CC_STACKPROTECTOR=y # CONFIG_CC_STACKPROTECTOR_NONE is not set CONFIG_CC_STACKPROTECTOR_REGULAR=y # CONFIG_CC_STACKPROTECTOR_STRONG is not set Host: Linux genericarmv7a 3.14.0 #2 SMP Mon Apr 21 14:51:04 PDT 2014 armv7l GNU/Linux Snapshot: version 2.5/0.158, commit release-2.4-448-g80d1a1b3c06d + changes GCC: 4.8.3 [gcc Linaro GCC 4.8-2014.02) 4.8.3 20140203 (prerelease)] Distro: Linux SElinux: unknown > -Will > >> >> ARCH: arm >> --------------- >> >> kernel version: 3.14.0-linaro-arndale >> systemtap location: /usr/local/bin/stap >> systemtap version: version 2.5/0.158, commit >> release-2.4-489-ge5fb7aeea34b + changes >> gcc location: /usr/bin/gcc >> gcc version: gcc (Ubuntu/Linaro 4.8.1-10ubuntu8) 4.8.1 >> >> >> **** failed systemtap kernel-devel smoke test: >> >> Makefile:622: Cannot use CONFIG_CC_STACKPROTECTOR_REGULAR: >> -fstack-protector not supported by compiler Most likely it is exactly what module build make says above: either compiler too old or not configured correctly. Try to compile something with -fstack-protector and see whether compilation is fine. Possible workarounds are either upgrade compiler or configure kernel without CONFIG_CC_STACKPROTECTOR_REGULAR, i.e CONFIG_CC_STACKPROTECTOR_NONE=y Thanks, Victor >> In file included from include/linux/kobject.h:21:0, >> from include/linux/module.h:16, >> from /usr/local/share/systemtap/runtime/linux/runtime.h:14, >> from /usr/local/share/systemtap/runtime/runtime.h:24, >> from >> /tmp/stap5eHu9T/stap_bdd64b2c1a0e84441832fdc380015719_878_src.c:24: >> include/linux/sysfs.h: In function 'sysfs_get_dirent': >> include/linux/sysfs.h:449:2: error: pointer targets in passing >> argument 2 of 'kernfs_find_and_get' differ in signedness >> [-Werror=pointer-sign] >> return kernfs_find_and_get(parent, name); >> ^ >> In file included from include/linux/sysfs.h:15:0, >> from include/linux/kobject.h:21, >> from include/linux/module.h:16, >> from /usr/local/share/systemtap/runtime/linux/runtime.h:14, >> from /usr/local/share/systemtap/runtime/runtime.h:24, >> from >> /tmp/stap5eHu9T/stap_bdd64b2c1a0e84441832fdc380015719_878_src.c:24: >> include/linux/kernfs.h:331:1: note: expected 'const char *' but >> argument is of type 'const unsigned char *' >> kernfs_find_and_get(struct kernfs_node *kn, const char *name) >> ^ >> cc1: all warnings being treated as errors >> make[4]: *** [/tmp/stap5eHu9T/stap_bdd64b2c1a0e84441832fdc380015719_878_src.o] >> Error 1 >> make[3]: *** [_module_/tmp/stap5eHu9T] Error 2 >> WARNING: kbuild exited with status: 2 >> Pass 4: compilation failed. [man error::pass4] >> >> **** aborting testing. >> >> make[2]: Leaving directory `/root/systemtap/testsuite' >> if test -n ""; then mail < systemtap.sum; fi >> make[1]: Leaving directory `/root/systemtap/testsuite' >> >> Please let me know if you need more information. >> >> Best regards >> Naresh Kamboju >> >