public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: hai wu <haiwu.us@gmail.com>
To: systemtap@sourceware.org
Subject: Re: [PATCH] filename in tapset nfs.proc.open and nfs.proc.release
Date: Mon, 15 Dec 2014 19:11:00 -0000	[thread overview]
Message-ID: <CAJ1=nZdVcdeRic+wcwa40PW8_G5QJz2YL=CgATEBBAA=TOm-TA@mail.gmail.com> (raw)
In-Reply-To: <CAJ1=nZcYtxopEs-XGj-Cs89dfzA2LF8oScnc_b+JE1zysg1T=Q@mail.gmail.com>

It turns out the above works fine in RHEL5.9 but not in RHEL6. In
RHEL6, the line needs to be changed to the following instead:

filename = task_dentry_path(task_current(), $filp->f_path->dentry,
$filp->f_path->mnt)

On Sat, Dec 13, 2014 at 10:35 PM, hai wu <haiwu.us@gmail.com> wrote:
> tapset nfs.proc.open and nfs.proc.release in nfs_proc.stp only records
> file's basename, which is not helpful when we use it to monitor NFS
> file access activities.
>
> The following patch would allow us to be able to see the full path for
> NFS file, along with its NFS mount information.
>
> diff --git a/tapset/linux/nfs_proc.stp b/tapset/linux/nfs_proc.stp
> index 1339aee..5a804e4 100644
> --- a/tapset/linux/nfs_proc.stp
> +++ b/tapset/linux/nfs_proc.stp
> @@ -1658,7 +1658,7 @@ probe nfs.proc.open = kernel.function("nfs_open") !,
>         prot = get_prot_from_client(client)
>         version = __nfs_version($inode)
>
> -       filename = __file_filename($filp)
> +  filename = task_dentry_path(task_current(), $filp->f_dentry, $filp->f_vfsmnt)
>         flag = $filp->f_flags
>         mode = $filp->f_mode
>
> @@ -1693,7 +1693,7 @@ probe nfs.proc.release = kernel.function("nfs_release") !,
>         prot = get_prot_from_client(client)
>         version = __nfs_version($inode)
>
> -       filename = __file_filename($filp)
> +  filename = task_dentry_path(task_current(), $filp->f_dentry, $filp->f_vfsmnt)
>         flag = $filp->f_flags
>         mode = $filp->f_mode

  reply	other threads:[~2014-12-15 19:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-14  4:35 hai wu
2014-12-15 19:11 ` hai wu [this message]
2014-12-15 20:07 ` David Smith
2014-12-15 20:34   ` Frank Ch. Eigler
2014-12-17 15:11     ` David Smith
2014-12-17 17:36       ` Lukas Berk
2014-12-17 19:46         ` David Smith
2014-12-18  0:07           ` Lukas Berk
2014-12-18  2:06             ` Frank Ch. Eigler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAJ1=nZdVcdeRic+wcwa40PW8_G5QJz2YL=CgATEBBAA=TOm-TA@mail.gmail.com' \
    --to=haiwu.us@gmail.com \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).