public inbox for systemtap@sourceware.org
 help / color / mirror / Atom feed
From: David Smith <dsmith@redhat.com>
To: Arkady <arkady.miasnikov@gmail.com>
Cc: systemtap@sourceware.org
Subject: Re: Integration of the shared memory based transport in the SystemTap
Date: Wed, 12 Jul 2017 12:35:00 -0000	[thread overview]
Message-ID: <CAKFOr-YzjT7VfU9HR7kJ3n6AW4TmE2m7wyaYPzseT-9L02f8eg@mail.gmail.com> (raw)
In-Reply-To: <CANA-60qz=xh942JZeG6UGhZZCfWeoKmA0AXr=+HZ2Tg8DpCfvg@mail.gmail.com>

I wonder if you wouldn't take a look at the existing ring buffer code
in the transport. We had it working at one point, but then never quite
pushed it over the finish line. I'm sure it needs some updates for
kernel changes. The advantage here would be that we're using an
existing kernel interface instead of rolling our own. Plus, a good bit
of the work has been done to integrate it with systemtap already. Look
in runtime/transport/ring_buffer.c.

On Tue, Jul 11, 2017 at 1:59 AM, Arkady <arkady.miasnikov@gmail.com> wrote:
> Hi,
>
> I have an implementation of shared memory which is, hopefully, rather
> close to the production grade. The idea is that a probe allocates a
> small chunk from the FIFO, fills the chunk with the data, "commits"
> the chunk. The FIFO can be lockless if there is a FIFO per core.
>
> This is the API in the kernel space
> https://gist.github.com/larytet/4977626fd87817414c7a88dd63e7855d
>
> In the user space the shared memory provides write()/read()/mmap() interfaces.
>
> I am going to patch the SystemTap by adding the API into the C code.
>
> I wonder if there is a chance for making the shared memory a first
> class citizen in the STAP and what will it take to merge the API into
> the mainline.
>
> Thank you, Arkady.



-- 
David Smith
Principal Software Engineer
Red Hat

  reply	other threads:[~2017-07-12 12:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-11  6:59 Arkady
2017-07-12 12:35 ` David Smith [this message]
2017-07-12 13:03   ` Arkady

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKFOr-YzjT7VfU9HR7kJ3n6AW4TmE2m7wyaYPzseT-9L02f8eg@mail.gmail.com \
    --to=dsmith@redhat.com \
    --cc=arkady.miasnikov@gmail.com \
    --cc=systemtap@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).