From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-lf1-x130.google.com (mail-lf1-x130.google.com [IPv6:2a00:1450:4864:20::130]) by sourceware.org (Postfix) with ESMTPS id 8836D385800A for ; Wed, 13 Jan 2021 04:49:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 8836D385800A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=2ndquadrant.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=craig.ringer@2ndquadrant.com Received: by mail-lf1-x130.google.com with SMTP id b26so836591lff.9 for ; Tue, 12 Jan 2021 20:49:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=mime-version:from:date:message-id:subject:to:cc; bh=ipe87+tx+Zi5visjjsptavNZz3MoRPrqhjNqoh8fwiU=; b=ajIvgCq42XRRPVc4LLjHQI7rpsdKNWZMCqLXIR+WX2JWvald7+UZBZVoq2QC4FhxEN Ndt4ZnyOXhN9D9Whavk6n9Hc/zpGmqviwthMSAKrsVmIperOaYG1585y5jZC1JmFEPym HP3RCTOLAnVS5MjyDTIDbZubuErEwmf/54ogpPXcfoFWs8sEv3j3ur0YWPfw/QETYvaA 40yBXeghLKrnWGqZpbWhMFUp26qpCSB5qXFnxoN7MgZD/VS755IboJLX0+YuFWnJ4/Hg yNdZFWB7uA24nEhkRenjdyeH/1sa7l+C4uitKQgvXXCCJ6EUjCuzoXsZqBURwKLpWu+o 5NPw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to:cc; bh=ipe87+tx+Zi5visjjsptavNZz3MoRPrqhjNqoh8fwiU=; b=ckkZJGlEHsSCuyyZYcbYd7KDnWHXuqKC3oxKiuvkTPcDR0HWT25hxQR8xmXiEWm5k6 ZWv/Z/xC/rXtN4Cy0NrEENNkPe5CEWD3eqtif4vj3sZy9Zumh3jPHmuReSbFivNzvg9d M3TFAs6QwUFQm+aNpizFAKzgHVjR9iLMohQt7Y7sbDiz2Ry7EEOEiIjDhNsqK2m0FnGy SYTDIewD1/BONlwouBk01v0OgnHsNmliS+n5f9Ab4L/yjSjfpOQPKI+cRF4ulJ28MkIK tpI7mY4Xg9QTTh6xfuJ1CUDtz61fceCo6zIoNDriEB7MU94vFROSzxnHqduZZX26bGC7 Q2TQ== X-Gm-Message-State: AOAM5301LCzowtqof1sMKksoQ3uBaFbW9azOSdyU7HKu7F1YHrT8hBbO WvNVI7iQm4mvTbu76g/PHCQKjmOPjVLPsX/I4ovvCrSAxZpJkA== X-Google-Smtp-Source: ABdhPJxzi3adABqFdYWNvHNbeZMyAvp3YnEvuEVEpKaPq/U/ofJQlGB63tklVeTfWDgtfmV88zJk02GDNrPfpsatqG4= X-Received: by 2002:a05:6512:2287:: with SMTP id f7mr62186lfu.40.1610513379048; Tue, 12 Jan 2021 20:49:39 -0800 (PST) MIME-Version: 1.0 From: Craig Ringer Date: Wed, 13 Jan 2021 12:49:27 +0800 Message-ID: Subject: Emitting marker names instead of hex statement addresses for SDT probes? To: systemtap@sourceware.org Cc: "Frank Ch. Eigler" X-Spam-Status: No, score=-1.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, HTML_MESSAGE, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 X-BeenThere: systemtap@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Systemtap mailing list List-Unsubscribe: , List-Archive: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 13 Jan 2021 04:49:42 -0000 Hi all I'm looking for advice on how feasible it might be to have systemtap report the SDT marker name in the probe-point name, instead of a .statement(0xdeadbeef) string. Because probes like process("foo").mark("bar") are converted to process("foo").statement(0xdeadbeef), the monitor mode display is nearly useless for SDTs. You just get a wall of undifferentiated hex statement addresses. It also makes various errors and diagnostics much more difficult to act on, and makes the output of pp() nearly useless for SDT markers. Any advice on where I might start looking in the code if I wanted to change this? Also, ideally I'd also like to have $$name do something sensible for all probe point types, so I don't need to defined($$name) ? $$name : ppfunc() in macros and functions that can be invoked by both marker based and DWARF-based probes. Any thoughts on the most sensible value to assign to $$name for other probe types? It could resolve to pp(), but that can be very long and verbose. ppfunc() would be logical for function based probes but for others it's less obvious. -- Craig Ringer http://www.2ndQuadrant.com/ 2ndQuadrant - PostgreSQL Solutions for the Enterprise