From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24507 invoked by alias); 28 Feb 2006 02:40:12 -0000 Received: (qmail 24443 invoked by uid 22791); 28 Feb 2006 02:40:11 -0000 X-Spam-Status: No, hits=-2.0 required=5.0 tests=AWL,BAYES_00 X-Spam-Check-By: sourceware.org Received: from fmr22.intel.com (HELO scsfmr002.sc.intel.com) (143.183.121.14) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 28 Feb 2006 02:40:08 +0000 Received: from scsfmr101.sc.intel.com (scsfmr101.sc.intel.com [10.3.253.10]) by scsfmr002.sc.intel.com (8.12.10/8.12.10/d: major-outer.mc,v 1.1 2004/09/17 17:50:56 root Exp $) with ESMTP id k1S2e4cA005641 for ; Tue, 28 Feb 2006 02:40:04 GMT Received: from scsmsxvs041.sc.intel.com (scsmsxvs041.sc.intel.com [10.3.90.10]) by scsfmr101.sc.intel.com (8.12.10/8.12.10/d: major-inner.mc,v 1.2 2004/09/17 18:05:01 root Exp $) with SMTP id k1S2Yjk2002220 for ; Tue, 28 Feb 2006 02:34:45 GMT Received: from scsmsx332.amr.corp.intel.com ([10.3.90.6]) by scsmsxvs041.sc.intel.com (SAVSMTP 3.1.7.47) with SMTP id M2006022718400428115 for ; Mon, 27 Feb 2006 18:40:04 -0800 Received: from scsmsx403.amr.corp.intel.com ([10.3.90.18]) by scsmsx332.amr.corp.intel.com with Microsoft SMTPSVC(6.0.3790.211); Mon, 27 Feb 2006 18:40:04 -0800 X-MimeOLE: Produced By Microsoft Exchange V6.5.7226.0 Content-class: urn:content-classes:message MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Subject: FW: [Bug translator/901] static validator Date: Tue, 28 Feb 2006 02:40:00 -0000 Message-ID: X-MS-Has-Attach: X-MS-TNEF-Correlator: Thread-Topic: [Bug translator/901] static validator Thread-Index: AcY8DuIsE9XBZWnrRU2puftfeW1fFAAABAcg From: "Stone, Joshua I" To: "SystemTap" X-OriginalArrivalTime: 28 Feb 2006 02:40:04.0136 (UTC) FILETIME=[47619A80:01C63C10] X-Scanned-By: MIMEDefang 2.52 on 10.3.253.10 X-IsSubscribed: yes Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org X-SW-Source: 2006-q1/txt/msg00655.txt.bz2 I've checked in a static validator for SystemTap modules, and I would like to get feedback on it. You can find it in 'src/safety/safety.py'. It checks modules for legal external references, and parses the disassembly for legal opcodes. For the allowed references file, I simply compiled all of the sample and buildok scripts I could find and added all of their references to the allowed list. I did only minimal verification on this, so it could very well need some pruning. For allowed opcodes, I've compiled the list for i686 and x86_64. I believe everything is covered & allowable in there, but it's of course open for review. The only surprise to me was 'movaps', but that instruction is actually very common within the kernel. I welcome comments and suggestions for improvement... Thanks, Josh joshua dot i dot stone at intel dot com wrote: > ------- Additional Comments From joshua dot i dot stone at intel dot > com 2006-02-28 02:29 ------- > A static safety checker has been committed to CVS. It checks for=20 > whitelisted opcodes and external references, with initial support > for i686 and x86_64. Adding other platforms is mostly a matter of > defining the allowed opcodes...=20