From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 84297 invoked by alias); 22 Mar 2018 08:02:29 -0000 Mailing-List: contact systemtap-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Post: List-Help: , Sender: systemtap-owner@sourceware.org Received: (qmail 84282 invoked by uid 89); 22 Mar 2018 08:02:28 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-12.6 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,SPF_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=integrating, Manager X-HELO: rcdn-iport-8.cisco.com Received: from rcdn-iport-8.cisco.com (HELO rcdn-iport-8.cisco.com) (173.37.86.79) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Mar 2018 08:02:26 +0000 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0AxAwD3YbNa/4sNJK1dGQEBAQEBAQE?= =?us-ascii?q?BAQEBAQcBAQEBAYM9YXAojDqMLYFRIYEQklcUgXILJ4ReAoNXITYWAQIBAQE?= =?us-ascii?q?BAQECayiFJQEBAQMBOAI/BQsLDgouVwYThQYID61RiEKBdgWFL4IRghOBOoI?= =?us-ascii?q?kNIMTAgEBGYEQARIBB4VtA4c1hGNqhAiGdAiFXoJhh2uDdIJqhGyJHoZHAgQ?= =?us-ascii?q?LAhMBgSUjAy5hcU0jFYJ9giEYjjYfMAEJjhCCNgEB?= Received: from alln-core-6.cisco.com ([173.36.13.139]) by rcdn-iport-8.cisco.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 22 Mar 2018 08:02:21 +0000 Received: from sjc-ads-6991 (sjc-ads-6991.cisco.com [10.30.218.111]) by alln-core-6.cisco.com (8.14.5/8.14.5) with ESMTP id w2M82JHn005534 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Thu, 22 Mar 2018 08:02:19 GMT Date: Thu, 22 Mar 2018 08:02:00 -0000 From: Victor Kamensky To: David Smith cc: systemtap@sourceware.org Subject: Re: [PATCH 0/6] systemtap set of --sysroot option handling fixes In-Reply-To: Message-ID: References: <1520271479-7960-1-git-send-email-kamensky@cisco.com> User-Agent: Alpine 2.00 (LRH 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed X-IsSubscribed: yes X-SW-Source: 2018-q1/txt/msg00099.txt.bz2 Hi David, On Wed, 21 Mar 2018, David Smith wrote: > Victor, > > I've checked in all your patches at this point. If anything still > doesn't work, please let me know. Appreciate very much time you spent integrating patches. I went through all my test cases on latest systemtap tree. All fixes except test case for 'PATCH 2' [1] looks good. 'PATCH 2' [1] for sysroot and short -r option did not come out quite right. For this combination systemtap code still calls dwfl_linux_kernel_report_offline function with short release version stored into elfutils_kernel_path and it cannot find kernel or kernel modules. In the case of sysroot and short -r option absolute path should be constructed instead, in order for dwfl_linux_kernel_report_offline to pick up kernel modules inside of sysroot. I will post follow up adjustment for PATCH 2 issue right after this email. If you would like to tweak it please send patch candidate back and I will give it a spin on my test case. > In addition, I tried to add test cases for all the items you found in > commit c96dfba71: > > Yes, I saw it. It looks great. > If you get a chance, I'd appreciate you looking it over and see if > there is anything else you think we should test. Will do. [1] https://sourceware.org/ml/systemtap/2018-q1/msg00067.html Thanks, Victor > Thanks again for all the patches! > > > On Mon, Mar 5, 2018 at 11:37 AM, Victor Kamensky wrote: >> Hi Folks, >> >> Here is set of fixes for SystemTap --sysroot option handling. >> >> Please look at individual patches decsription for issues observed and fixed. >> >> If commit messages are too details and big for SystemTap project >> guidelines feel free to trim them. Commit message structured in such >> way that text after "Here are steps how to reproduce the issue." could >> be removed if needed. >> >> I did not run full SystemTap regression with --sysroot option since SystemTap >> DejaGnu testsuites are not friendly to remote execution mode. I did run >> regular 'make installcheck' on the same baseline with and without changes >> and made sure that results are identical. >> >> If you would like to try stap in cross compiled environment with --sysroot >> option I've set up openembedded-core repository where these changes are >> integrated and since openembedded-core support virtual qemu based target >> for different CPU types stap with --sysroot option could be tested. >> >> Setup instructions are here: >> https://github.com/victorkamensky/systemtap-oe-sysroot-manifest >> >> Victor Kamensky (6): >> sysroot: fix short release -r option handling in case of sysroot read >> System.map symbols >> sysroot: fix short release -r option handling in case of sysroot pass >> proper kernel modules >> sysroot: debuginfo lookup with sysroot case do not remove sysroot from >> file_name >> sysroot: delay adding sysroot path to module name in case of non >> absolute executable >> sysroot: handle symbolic links with absolute name relative to sysroot >> sysroot: _stp_umodule_relocate needs receive target file path >> >> loc2stap.cxx | 3 ++- >> session.cxx | 2 +- >> setupdwfl.cxx | 28 ++++++++++------------ >> tapsets.cxx | 8 +++---- >> util.cxx | 76 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ >> 5 files changed, 96 insertions(+), 21 deletions(-) >> >> -- >> 2.14.3 >> > > > > -- > David Smith > Associate Manager > Red Hat >